Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create applied-clay-science-chronologically.csl #3636

Merged
merged 4 commits into from Dec 27, 2018

Conversation

@matejovo
Copy link
Contributor

matejovo commented Aug 6, 2018

1.Citation format:
-References in the text should be reported by increasing chronological
order

Citations in the text may be made parenthetically groups of references should be listed first chronologically, then alphabetically for the same year.

1.Citation format:
-References in the text should be reported by increasing chronological 
order

Citations in the text may be made parenthetically groups of references should be listed first chronologically, then alphabetically for the same year.
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Aug 6, 2018

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Aug 6, 2018

😟 There are some issues with your submission. Please check the test report for details.

@matejovo matejovo changed the title Create applied-clay-science-chronologically Create applied-clay-science-chronologically.csl Aug 6, 2018
…hronologically.csl
Copy link
Contributor Author

matejovo left a comment

.csl

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Aug 6, 2018

😟 There are some issues with your submission. Please check the test report for details.

@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Aug 6, 2018

you're creating a bit of chaos here ;). Please hold off on pull requests for now and explain what exactly it is you're trying to do. Am I understanding you that the current style for applied clay sciences is incorrect and you're just trying to fix it by ordering in-text citations chronologically?

@adam3smith adam3smith added the waiting label Aug 7, 2018
@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented Dec 24, 2018

@POBrien333, do you mind taking a look?

The current CSL style (https://github.com/citation-style-language/styles/blob/master/dependent/applied-clay-science.csl) is a dependent of Elsevier Harvard (https://github.com/citation-style-language/styles/blob/master/elsevier-harvard.csl), which (presumably correctly) doesn't sort citations primarily by year. Per above, the journal instructions at https://www.elsevier.com/journals/applied-clay-science/01691317/guide-for-authors say:

Citations in the text should be given in chronological order.

and

Citations in the text may be made parenthetically groups of references should be listed first chronologically, then alphabetically for the same year.

  • Examples of papers in a text:
    (Bergaya et al., 1999; Allan and Jones, 1999, 2000a, 2000b; Allan, 2015) and (Tunney and Detellier, 1996; Letaief and Detellier, 2007; Tonlé et al., 2007, 2009; de Faria et al., 2009, 2010, 2011; Yang et > al., 2012; Matusik and W?cis?o, 2014)
@POBrien333

This comment has been minimized.

Copy link
Contributor

POBrien333 commented Dec 24, 2018

I can confirm. The style was not correct and the suggested style by matejovo fixes the issue.
Checked in guidelines and papers.

rmzelle added 2 commits Dec 27, 2018
…-clay-science.csl
@stale stale bot removed the waiting label Dec 27, 2018
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Dec 27, 2018

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Dec 27, 2018

😃 Your submission passed all our automated tests.

@rmzelle rmzelle merged commit 3d56104 into citation-style-language:master Dec 27, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented Dec 27, 2018

Great, thanks both.

Corresponding exemption in journals repo at citation-style-language/journals@c666444.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.