Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ausonius-editions-new.csl #4082

Merged
merged 9 commits into from Jul 14, 2019

Conversation

@ColineRuizDarasse
Copy link
Contributor

ColineRuizDarasse commented May 6, 2019

Fixing document name.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented May 6, 2019

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented May 6, 2019

😟 There are some issues with your submission. Please check the test report for details.

@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented May 7, 2019

Could you say how this relates to the existing Ausonious Editions style? Is it based on it? What changed? Should this replace the existing style?

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented May 7, 2019

😃 Your submission passed all our automated tests.

@ColineRuizDarasse

This comment has been minimized.

Copy link
Contributor Author

ColineRuizDarasse commented May 7, 2019

Hi,
this is an updated version of the Ausonius Edition style. It presented bugs notably for book chapters and conference proceedings, as well as for dictionary entries. We have slightly modified it and we would like to make it available on the Zotero style depository.

@ColineRuizDarasse

This comment has been minimized.

Copy link
Contributor Author

ColineRuizDarasse commented May 7, 2019

It would replace the former one, indeed.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented May 16, 2019

😃 Your submission passed all our automated tests.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented May 16, 2019

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented May 16, 2019

😟 There are some issues with your submission. Please check the test report for details.

@stale

This comment has been minimized.

Copy link

stale bot commented Jun 15, 2019

This issue hasn't seen any activity in the past 30 days. It will be automatically closed if no further activity occurs in the next two weeks.

@stale stale bot added the waiting label Jun 15, 2019
@stale stale bot closed this Jun 29, 2019
@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Jun 29, 2019

reopening

@adam3smith adam3smith reopened this Jun 29, 2019
@stale stale bot removed the waiting label Jun 29, 2019
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jun 29, 2019

😟 There are some issues with your submission.

3 tests failed

ausonius-editions: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[0, "1:19: FATAL: parsing XML declaration: '?>' expected"]].empty?` to return true, got false

ausonius-editions: style ID must be of the form "http://www.zotero.org/styles/" + style file name (without ".csl" extension, e.g. "http://www.zotero.org/styles/apa")

expected: "http://www.zotero.org/styles/ausonius-editions"
     got: "http://www.zotero.org/styles/ausonius"

(compared using ==)

ausonius-editions: "self" link must match the style ID

expected: "http://www.zotero.org/styles/ausonius-editions-new"
     got: "http://www.zotero.org/styles/ausonius"

(compared using ==)

Please check the test report for details.

rmzelle added 2 commits Jul 1, 2019
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jul 1, 2019

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

ausonius-editions-new.csl (new)
Hancké et al., eds.  ; 2007 ; CSL search by example  ; 2012
Mares  ; 2001 ; Fenner et al.  ; 2019

 (2012) : CSL search by example (http://editor.citationstyles.org/searchByExample/, accessed 15 December 2012).
Fenner, M., M. Crosas, J.S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone and T. Clark (2019) : “A data citation roadmap for scholarly data repositories,” Scientific Data, 6, 1, 28.
Hancké, B., M. Rhodes and M. Thatcher, eds. (2007) : Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy, Oxford and New York.
Mares, I. (2001) : “Firms and the welfare state: When, why, and how does social policy matter to employers?”, in : Hall & Soskice, eds. 2001, 184–213.
ausonius-editions.csl (modified style; unchanged output for sample items)
Hancké et al., eds.  ; 2007 ; CSL search by example  ; 2012
Mares  ; 2001 ; Fenner et al.  ; 2019

 (2012) : CSL search by example (http://editor.citationstyles.org/searchByExample/, accessed 15 December 2012).
Fenner, M., M. Crosas, J.S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone and T. Clark (2019) : “A data citation roadmap for scholarly data repositories,” Scientific Data, 6, 1, 28.
Hancké, B., M. Rhodes and M. Thatcher, eds. (2007) : Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy, Oxford and New York.
Mares, I. (2001) : “Firms and the welfare state: When, why, and how does social policy matter to employers?”, in : Hall & Soskice, eds. 2001, 184–213.
@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented Jul 1, 2019

@adam3smith, can you review and merge these changes? I updated the original "ausonius-editions.csl" with the version in "ausonius-editions-new.csl" and made a few corrections (restored style title, author name). Should be good to go once we delete "ausonius-editions-new.csl" from the patch-4 branch, or we commit separately from this PR.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jul 1, 2019

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

ausonius-editions-new.csl (new)
Hancké et al., eds.  ; 2007 ; CSL search by example  ; 2012
Mares  ; 2001 ; Fenner et al.  ; 2019

 (2012) : CSL search by example (http://editor.citationstyles.org/searchByExample/, accessed 15 December 2012).
Fenner, M., M. Crosas, J.S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone and T. Clark (2019) : “A data citation roadmap for scholarly data repositories,” Scientific Data, 6, 1, 28.
Hancké, B., M. Rhodes and M. Thatcher, eds. (2007) : Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy, Oxford and New York.
Mares, I. (2001) : “Firms and the welfare state: When, why, and how does social policy matter to employers?”, in : Hall & Soskice, eds. 2001, 184–213.
ausonius-editions.csl (modified style; unchanged output for sample items)
Hancké et al., eds.  ; 2007 ; CSL search by example  ; 2012
Mares  ; 2001 ; Fenner et al.  ; 2019

 (2012) : CSL search by example (http://editor.citationstyles.org/searchByExample/, accessed 15 December 2012).
Fenner, M., M. Crosas, J.S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone and T. Clark (2019) : “A data citation roadmap for scholarly data repositories,” Scientific Data, 6, 1, 28.
Hancké, B., M. Rhodes and M. Thatcher, eds. (2007) : Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy, Oxford and New York.
Mares, I. (2001) : “Firms and the welfare state: When, why, and how does social policy matter to employers?”, in : Hall & Soskice, eds. 2001, 184–213.
adam3smith added 2 commits Jul 6, 2019
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jul 6, 2019

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

ausonius-editions-new.csl (new)
Hancké et al., eds.  ; 2007 ; CSL search by example  ; 2012
Mares  ; 2001 ; Fenner et al.  ; 2019

 (2012) : CSL search by example (http://editor.citationstyles.org/searchByExample/, accessed 15 December 2012).
Fenner, M., M. Crosas, J.S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone and T. Clark (2019) : “A data citation roadmap for scholarly data repositories,” Scientific Data, 6, 1, 28.
Hancké, B., M. Rhodes and M. Thatcher, eds. (2007) : Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy, Oxford and New York.
Mares, I. (2001) : “Firms and the welfare state: When, why, and how does social policy matter to employers?”, in : Hall & Soskice, eds. 2001, 184–213.
ausonius-editions.csl (modified style)
Hancké et al., eds.  ; 2007 ; CSL search by example  ; 2012
Mares  ; 2001 ; Fenner et al.  ; 2019

 (2012) : CSL search by example (http://editor.citationstyles.org/searchByExample/, accessed 15 December 2012).
Fenner, M., M. Crosas, J.S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone and T. Clark (2019) : “A data citation roadmap for scholarly data repositories,” Scientific Data, 6, 1, 28.
Hancké, B., M. Rhodes and M. Thatcher, eds. (2007) : Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy, Oxford and New York.
Mares, I. (2001) : “Firms and the welfare state: When, why, and how does social policy matter to employers?,” in : Hall & Soskice, eds. 2001, 184–213.
 Hancké <i>et al.</i>, eds.  ; 2007 ; CSL search by example  ; 2012<br/>
 Mares  ; 2001 ; Fenner <i>et al.</i>  ; 2019<br/>
 <hr/>
  (2012) : <i>CSL search by example</i> (http://editor.citationstyles.org/searchByExample/, accessed 15 December 2012).<br/>
 Fenner, M., M. Crosas, J.S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone and T. Clark (2019) : “A data citation roadmap for scholarly data repositories,” <i>Scientific Data</i>, 6, 1, 28.<br/>
 Hancké, B., M. Rhodes and M. Thatcher, eds. (2007) : <i>Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy</i>, Oxford and New York.<br/>
-Mares, I. (2001) : “Firms and the welfare state: When, why, and how does social policy matter to employers?”, in : Hall &amp; Soskice, eds. 2001, 184–213.<br/>
+Mares, I. (2001) : “Firms and the welfare state: When, why, and how does social policy matter to employers?,” in : Hall &amp; Soskice, eds. 2001, 184–213.<br/>
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jul 6, 2019

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

ausonius-editions.csl (modified style)
Hancké et al., eds.  ; 2007 ; CSL search by example  ; 2012
Mares  ; 2001 ; Fenner et al.  ; 2019

 (2012) : CSL search by example (http://editor.citationstyles.org/searchByExample/, accessed 15 December 2012).
Fenner, M., M. Crosas, J.S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone and T. Clark (2019) : “A data citation roadmap for scholarly data repositories,” Scientific Data, 6, 1, 28.
Hancké, B., M. Rhodes and M. Thatcher, eds. (2007) : Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy, Oxford and New York.
Mares, I. (2001) : “Firms and the welfare state: When, why, and how does social policy matter to employers?,” in : Hall & Soskice, eds. 2001, 184–213.
 Hancké <i>et al.</i>, eds.  ; 2007 ; CSL search by example  ; 2012<br/>
 Mares  ; 2001 ; Fenner <i>et al.</i>  ; 2019<br/>
 <hr/>
  (2012) : <i>CSL search by example</i> (http://editor.citationstyles.org/searchByExample/, accessed 15 December 2012).<br/>
 Fenner, M., M. Crosas, J.S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone and T. Clark (2019) : “A data citation roadmap for scholarly data repositories,” <i>Scientific Data</i>, 6, 1, 28.<br/>
 Hancké, B., M. Rhodes and M. Thatcher, eds. (2007) : <i>Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy</i>, Oxford and New York.<br/>
-Mares, I. (2001) : “Firms and the welfare state: When, why, and how does social policy matter to employers?”, in : Hall &amp; Soskice, eds. 2001, 184–213.<br/>
+Mares, I. (2001) : “Firms and the welfare state: When, why, and how does social policy matter to employers?,” in : Hall &amp; Soskice, eds. 2001, 184–213.<br/>
@@ -134,7 +139,7 @@
<if is-numeric="edition">
<group delimiter=", ">

This comment has been minimized.

Copy link
@NMonteix

NMonteix Jul 6, 2019

Contributor

The comma should be removed, in order to avoid something like "2e, éd." for a second edition

@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Jul 14, 2019

Thanks @NMonteix ! Done

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jul 14, 2019

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

ausonius-editions.csl (modified style)
Hancké et al., eds.  ; 2007 ; CSL search by example  ; 2012
Mares  ; 2001 ; Fenner et al.  ; 2019

 (2012) : CSL search by example (http://editor.citationstyles.org/searchByExample/, accessed 15 December 2012).
Fenner, M., M. Crosas, J.S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone and T. Clark (2019) : “A data citation roadmap for scholarly data repositories,” Scientific Data, 6, 1, 28.
Hancké, B., M. Rhodes and M. Thatcher, eds. (2007) : Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy, Oxford and New York.
Mares, I. (2001) : “Firms and the welfare state: When, why, and how does social policy matter to employers?,” in : Hall & Soskice, eds. 2001, 184–213.
 Hancké <i>et al.</i>, eds.  ; 2007 ; CSL search by example  ; 2012<br/>
 Mares  ; 2001 ; Fenner <i>et al.</i>  ; 2019<br/>
 <hr/>
  (2012) : <i>CSL search by example</i> (http://editor.citationstyles.org/searchByExample/, accessed 15 December 2012).<br/>
 Fenner, M., M. Crosas, J.S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone and T. Clark (2019) : “A data citation roadmap for scholarly data repositories,” <i>Scientific Data</i>, 6, 1, 28.<br/>
 Hancké, B., M. Rhodes and M. Thatcher, eds. (2007) : <i>Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy</i>, Oxford and New York.<br/>
-Mares, I. (2001) : “Firms and the welfare state: When, why, and how does social policy matter to employers?”, in : Hall &amp; Soskice, eds. 2001, 184–213.<br/>
+Mares, I. (2001) : “Firms and the welfare state: When, why, and how does social policy matter to employers?,” in : Hall &amp; Soskice, eds. 2001, 184–213.<br/>
@adam3smith adam3smith merged commit 3f2cf92 into citation-style-language:master Jul 14, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Jul 14, 2019

Thanks! (Note that the comma is actually outside the quotation mark; preview gets that wrong)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.