Work on tests #1133

zuphilip · Sep 2, 2016

No description provided.

dstillman · Sep 2, 2016

dstillman reviewed Sep 2, 2016

View changes

dstillman · Sep 2, 2016

deleted.txt

@@ -79,3 +79,4 @@ f880bf79-d42f-4337-b0d2-7a7de4a48b7d # X-OPAC - no more instances of this lib ca
 0863b8ec-e717-4b6d-9e35-0b2db2ac6b0f # Physical Society of Japan - journals moved to IOP or Atypon system
 63c25c45-6257-4985-9169-35b785a2995e # InfoTrac OneFile - merged into Galegroup (see #482)
 79f6f9ed-537a-4d4f-8270-c4fbaafdf327 # Emerald; covered by Atypon
+9d822257-2eec-4674-b6d0-2504f54c8890 # African Journals Online; covered by Open Journal Systems


You have to bump the version number at the top of the file as well.

Done. Thanks.

(I can squash these these two commits together after the complete review.)

zuphilip · Sep 3, 2016

zuphilip reviewed Sep 3, 2016

View changes

zuphilip · Sep 3, 2016

AllAfrica.js

@@ -1,6 +1,6 @@
 {
 	"translatorID": "34B1E0EA-FD02-4069-BAE4-ED4D98674A5E",
-	"label": "allAfrica.com",
+	"label": "AllAfrica",


The label should match the filename, otherwise Scaffolds tries to overwrite this every time.

zuphilip · Sep 3, 2016

zuphilip reviewed Sep 3, 2016

View changes

zuphilip · Sep 3, 2016

African Journals Online.js

-	},
-	{
-		"type": "web",
-		"url": "http://www.ajol.info/index.php/thrb/article/view/63347",


We should add this test case in the OJS translator.

adam3smith · Sep 3, 2016

Let me know when you want me to look and/or merge. So far, this is looking great

zuphilip · Sep 3, 2016

Well, I think now is a good point for a review. I am through all translators starting with a and just skipping some complex/unfamiliar ones.

I would suggest to have multiple commits, but I can rebase them (after your review), such that all things related to African Journals Online are in one commit. What do you think?

adam3smith · Sep 3, 2016

In the past I often put commits with lots of minor changes and test updates in a single commit. Any strong reason to split them?

adam3smith · Sep 3, 2016

adam3smith reviewed Sep 3, 2016

View changes

adam3smith · Sep 3, 2016

AMS Journals.js

-	}
-	/*multiples are currently broken
-	else if (url.match(/jour(nals|search)/)) {
+	} else if (url.match(/jour(nals|search)/)) {


the regex looks suspect -- would it really be joursearch ? Couldn't get it to work with the site

The same name is used several lines below in the doWeb. However, currently the search inside a journal directs to another website and this service is not available at the moment. I will rewrite this part to use also getSearchResults-function and then we can check on that. Give me just some minutes...

Done rewriting.

zuphilip · Sep 3, 2016

That works as well. I guess that all "fix and update tests"-commits are similar and could be merged together. Maybe some changes are larger than a simple update, then this could be mentioned separately...

adam3smith · Sep 4, 2016

adam3smith reviewed Sep 4, 2016

View changes

adam3smith · Sep 4, 2016

ASCO Meeting Library.js

@@ -72,6 +72,7 @@ var testCases = [
 		"items": [
 			{
 				"itemType": "journalArticle",
+				"title": "Denosumab versus placebo as adjuvant treatment for women with early-stage breast cancer at high risk of disease recurrence (D-CARE): An international, placebo-controlled, randomized, double-blind phase III clinical trial.",


it's in the old title, too, but let's remove the period at the end ot the title

adam3smith · Sep 4, 2016

adam3smith reviewed Sep 4, 2016

View changes

adam3smith · Sep 4, 2016

Atypon Journals.js

@@ -264,84 +264,6 @@ function scrape(doc, url, extras) {
 var testCases = [
 	{
 		"type": "web",
-		"url": "http://www.esajournals.org/doi/abs/10.1890/09-1234.1",


note for later: moved to Wiley

Okay, I opened an issue #1136

adam3smith · Sep 4, 2016

adam3smith reviewed Sep 4, 2016

View changes

adam3smith · Sep 4, 2016

Atypon Journals.js

@@ -619,13 +541,13 @@ var testCases = [
 				"date": "August 1, 2001",
 				"DOI": "10.1146/annurev.matsci.31.1.323",
 				"ISSN": "1531-7331",
-				"abstractNote": "▪ Abstract  A two-part review of research concerning block copolymer thin films is presented. The first section summarizes experimental and theoretical studies of the fundamental physics of these systems, concentrating upon the forces that govern film morphology. The role of film thickness and surface energetics on the morphology of compositionally symmetric, amorphous diblock copolymer films is emphasized, including considerations of boundary condition symmetry, so-called hybrid structures, and surface chemical expression. Discussions of compositionally asymmetric systems and emerging research areas, e.g., liquid-crystalline and A-B-C triblock systems, are also included. In the second section, technological applications of block copolymer films, e.g., as lithographic masks and photonic materials, are considered. Particular attention is paid to means by which microphase domain order and orientation can be controlled, including exploitation of thickness and surface effects, the application of external fields, and the use of patterned substrates.",
+				"abstractNote": "▪ Abstract A two-part review of research concerning block copolymer thin films is presented. The first section summarizes experimental and theoretical studies of the fundamental physics of these systems, concentrating upon the forces that govern film morphology. The role of film thickness and surface energetics on the morphology of compositionally symmetric, amorphous diblock copolymer films is emphasized, including considerations of boundary condition symmetry, so-called hybrid structures, and surface chemical expression. Discussions of compositionally asymmetric systems and emerging research areas, e.g., liquid-crystalline and A-B-C triblock systems, are also included. In the second section, technological applications of block copolymer films, e.g., as lithographic masks and photonic materials, are considered. Particular attention is paid to means by which microphase domain order and orientation can be controlled, including exploitation of thickness and surface effects, the application of external fields, and the use of patterned substrates.",


we could consider cleaning this up -- but given it's a generic translator and the square before the abstract is quite weird, I'll leave that up to you.

adam3smith · Sep 6, 2016

Thanks! -- 1 done, 25 letters to go ;)

zuphilip · Sep 6, 2016

👍 😏

zuphilip added some commits Sep 2, 2016

Delete African Journals Online.js; covered by OJS

fbf635f

Fix tests in AllAfrica.js

21a44e1

Update tests in AlterNet.js

1836b23

zuphilip added some commits Sep 3, 2016

Add test for African Journals Online in OJS

750bb83

Update tests in Atypon Journals.js
The esajournals moved to Wiley.

9c9d5b2

Fix multiples in arXiv.org.js

b3adc22

Rewrite AMS Journals.js

75f8c64

Update ASCO Meeting Library.js

771c612

Update Atypon Journals.js

2cf298f

adam3smith merged commit e102b02 into zotero:master Sep 6, 2016

zuphilip deleted the zuphilip:work-on-tests branch Sep 6, 2016

zotero/translators

Join GitHub today

Work on tests #1133

Conversation

zuphilip commented Sep 2, 2016

zuphilip added some commits Sep 2, 2016

dstillman reviewed Sep 2, 2016 View changes

This comment has been minimized.

This comment has been minimized.

zuphilip Sep 2, 2016 • edited

zuphilip added some commits Sep 2, 2016

zuphilip reviewed Sep 3, 2016 View changes

This comment has been minimized.

zuphilip reviewed Sep 3, 2016 View changes

This comment has been minimized.

zuphilip added some commits Sep 3, 2016

This comment has been minimized.

adam3smith commented Sep 3, 2016

This comment has been minimized.

zuphilip commented Sep 3, 2016

This comment has been minimized.

adam3smith commented Sep 3, 2016

adam3smith reviewed Sep 3, 2016 View changes

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

zuphilip commented Sep 3, 2016

adam3smith reviewed Sep 4, 2016 View changes

This comment has been minimized.

This comment has been minimized.

adam3smith reviewed Sep 4, 2016 View changes

This comment has been minimized.

This comment has been minimized.

adam3smith reviewed Sep 4, 2016 View changes

This comment has been minimized.

This comment has been minimized.

adam3smith merged commit e102b02 into zotero:master Sep 6, 2016

This comment has been minimized.

adam3smith commented Sep 6, 2016

zuphilip deleted the zuphilip:work-on-tests branch Sep 6, 2016

This comment has been minimized.

zuphilip commented Sep 6, 2016

zuphilip added a commit to zuphilip/translators that referenced this pull request Mar 28, 2018

zuphilip added a commit to zuphilip/translators that referenced this pull request Mar 28, 2018

dstillman reviewed Sep 2, 2016

View changes

zuphilip Sep 2, 2016 •

edited

zuphilip reviewed Sep 3, 2016

View changes

zuphilip reviewed Sep 3, 2016

View changes

adam3smith reviewed Sep 3, 2016

View changes

adam3smith reviewed Sep 4, 2016

View changes

adam3smith reviewed Sep 4, 2016

View changes

adam3smith reviewed Sep 4, 2016

View changes

adam3smith merged commit `e102b02` into zotero:master Sep 6, 2016