Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign up[ISTC.js]: Replace (deprecated) for each loops #1203
Conversation
zuphilip
reviewed
Dec 28, 2016
@@ -12,127 +12,128 @@ | |||
"lastUpdated": "2016-11-01 14:02:29" |
This comment has been minimized.
This comment has been minimized.
zuphilip
Dec 28, 2016
Collaborator
You have to increase the date here, in order to trigger the distribution to the clients.
This comment has been minimized.
This comment has been minimized.
It looks that you changed also some whitespaces because the diff shows that everything changed, where you only changed a few lines: https://github.com/zotero/translators/pull/1203/files?w=0 |
This comment has been minimized.
This comment has been minimized.
Yes. This is my IDE automatically converting newline characters. I scanned all translator files and it seems that this is the only one which had windows style newlines ( |
adomasven
force-pushed the
adomasven:fix/remove-deprecated-foreach
branch
from
37c7895
to
5416dd2
Dec 28, 2016
This comment has been minimized.
This comment has been minimized.
Okay, that looks good for me. |
adam3smith
merged commit 2b6221e
into
zotero:master
Dec 29, 2016
This comment has been minimized.
This comment has been minimized.
Great, thanks! |
adomasven commentedDec 28, 2016
Also change inconsistent line endings to be in line with the rest of translators using
\n