Skip to content

/translators

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes R #1320

Merged
merged 12 commits into from Jun 6, 2017
+475 −619

Conversation

@zuphilip
Copy link
Collaborator

commented Jun 4, 2017

No description provided.

@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Collaborator

commented Jun 4, 2017

Have a look at my fix for RePec and let me know what you think. Otherwise I think this is ready to go.
@zuphilip

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

commented Jun 5, 2017

The fix works fine (I just fixed the uppercase naming). Thank you! For the general problem I created an issue #1321. Ready to merge here.

@adam3smith adam3smith merged commit 95103c6 into zotero:master Jun 6, 2017
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Collaborator

commented Jun 6, 2017

Thanks -- agree with the ticket. This should be fixed, but I figured since there was an elegant fix available we'd just use that so that it doesn't hold up the whole pull request.
@zuphilip

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

commented Jun 6, 2017

Thank you. Yes, the PR was ready to merge.

The ticket can be solved later and the general problem seems to be part of the "sandboxing hell" 👹, but I don't have an idea about the details.

@zuphilip zuphilip deleted the zuphilip:fixes-R branch Feb 17, 2018

zuphilip added a commit to zuphilip/translators that referenced this pull request Mar 28, 2018

@zuphilip
Fixes R (zotero#1320) 
* Delete Readability.js as service was shut down
See https://medium.com/@readability/the-readability-bookmarking-service-will-shut-down-on-september-30-2016-1641cc18e02b for details
* Update REDALYC.js
* Update tests in RePEc - Econpapers.js
* Rewrite RePEc - IDEAS.js
* Update tests in Retsinformation.js
* Update test case
Also delete one test case which is now hosted at openedition.org
* Update Rock, Paper, Shotgun.js
* Delete ReliefWeb.js, see zotero#1319
* Rewrite Roll Call.js
* Update tests in RSC Publishing.js
fc86b56

zuphilip added a commit to zuphilip/translators that referenced this pull request Mar 28, 2018

@zuphilip
Fixes R (zotero#1320) 
* Delete Readability.js as service was shut down
See https://medium.com/@readability/the-readability-bookmarking-service-will-shut-down-on-september-30-2016-1641cc18e02b for details
* Update REDALYC.js
* Update tests in RePEc - Econpapers.js
* Rewrite RePEc - IDEAS.js
* Update tests in Retsinformation.js
* Update test case
Also delete one test case which is now hosted at openedition.org
* Update Rock, Paper, Shotgun.js
* Delete ReliefWeb.js, see zotero#1319
* Rewrite Roll Call.js
* Update tests in RSC Publishing.js
6860606
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@zuphilip @adam3smith
You can’t perform that action at this time.