Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd ProQuest Ebook Central #1480
Conversation
adam3smith
added
the
New Translator
label
Nov 18, 2017
adam3smith
requested a review
from zuphilip
Nov 18, 2017
zuphilip
reviewed
Nov 19, 2017
|
Okay, this looks good and I can test the same cases by simply replace your instition's name with mine. I have only found some small nits, which I will correct directly in a minute. |
zuphilip
merged commit 1d0e018
into
zotero:master
Nov 19, 2017
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
This comment has been minimized.
This comment has been minimized.
|
Thank you very much! |
This comment has been minimized.
This comment has been minimized.
|
Really enjoyed working with the built-in templates in Scaffold -- very nice work on those. |
adam3smith
deleted the
adam3smith:PQBooks
branch
Nov 19, 2017
psisquared2
added a commit
to psisquared2/translators
that referenced
this pull request
Feb 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
adam3smith commentedNov 18, 2017
Reported/requested here: https://forums.zotero.org/discussion/67872/proquest-ebook-central#latest
The test won't run anywhere but at Syracuse -- the Ebook Central libraries are all taylored to institutions -- but I figured it'd be better to have some tests than none and they can be localized by replacing the Syracuse-specific part.
Everything else should be straightforward