Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upCorrectly set the id number of an item selected in the sidebar #1641
Conversation
dstillman
merged commit fbbef89
into
zotero:master
Apr 27, 2018
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
fbennett
deleted the
Juris-M:hein-online
branch
Apr 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
fbennett commentedApr 27, 2018
•
edited
This pull request addresses #1639, and one of two issues involved in a report to the Zotero Forum.
The issue addressed here is a straight-up bug in the translator, in code that I wrote. Single-item saves worked fine on the initial visit to a page, but retrieved incorrect metadata after selecting another item from the left-hand ToC listing in the page. I apparently didn't manually test that action when I wrote the translator, and it has lurked in there for yonks until a librarian called us on it.
The second issue concerns the site itself, and is identified by @dstillman in the tracker issue and forum thread linked above.