Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New translator for Harvard Business Review #1669

Merged
merged 4 commits into from Oct 11, 2018

Conversation

@zuphilip
Copy link
Collaborator

commented Jun 1, 2018

New translator for Harvard Business Review

// translator.setDocument(doc);

// TODO there are sometimes also more than one article on the same page
// e.g. https://hbr.org/2017/07/the-trouble-with-cmos#the-power-partnership

This comment has been minimized.

Copy link
@zuphilip

zuphilip Jun 1, 2018

Author Collaborator

That is still a TODO...

This comment has been minimized.

Copy link
@adam3smith

adam3smith Aug 20, 2018

Collaborator

do you consider that a blocker or can we accept with this TODO?

This comment has been minimized.

Copy link
@zuphilip

zuphilip Aug 20, 2018

Author Collaborator

It is for me a major drawback: If I am in the middle of the page and want to save that article, then hit the Zotero button, it saves, but the article from the top.

@adam3smith
Copy link
Collaborator

left a comment

I have a couple of questions left, but we should be able to take this.

Show resolved Hide resolved Harvard Business Review.js
// translator.setDocument(doc);

// TODO there are sometimes also more than one article on the same page
// e.g. https://hbr.org/2017/07/the-trouble-with-cmos#the-power-partnership

This comment has been minimized.

Copy link
@adam3smith

adam3smith Aug 20, 2018

Collaborator

do you consider that a blocker or can we accept with this TODO?

Show resolved Hide resolved Harvard Business Review.js

@adam3smith adam3smith added the waiting label Aug 20, 2018

translator.setHandler('itemDone', function (obj, item) {
// sometimes the section is also falsly part of the title from EM
item.title = text(doc, 'h1.article-hed') || text(doc, 'h2.article-hed') || item.title;
// sometitmes the creators are not yet extracted by EM

This comment has been minimized.

Copy link
@zuphilip

zuphilip Aug 20, 2018

Author Collaborator

typo: sometitmes

@zuphilip zuphilip changed the title [WIP] New translator for Harvard Business Review New translator for Harvard Business Review Oct 10, 2018

@zuphilip zuphilip removed the waiting label Oct 10, 2018

@zuphilip

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 10, 2018

@adam3smith Okay, this is ready for review now.

@adam3smith

This comment has been minimized.

Copy link
Collaborator

commented Oct 11, 2018

Looks good to me. When I'm running the tests (and importing), I don't get a publication title. Is that due to recent changes we made to EM? If so, could we add this in manually? Also, please manually add the ISSN

@zuphilip

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 11, 2018

Yes, with the new version of the EM translator we need to add publicationTitle here again manually, also ISSN is a good hint to add. Thank you!

@zuphilip

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 11, 2018

Please have a look at the new version.

@adam3smith adam3smith merged commit dd5bf1c into zotero:master Oct 11, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Copy link
Collaborator

commented Oct 11, 2018

Great, thanks!

@zuphilip zuphilip deleted the zuphilip:hbr branch Oct 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.