Skip to content

/translators

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translator for svt.se #1688

Merged
merged 4 commits into from Sep 15, 2018

Conversation

@sebastian-berlin-wmse
Copy link
Contributor

commented Jul 5, 2018

This is the website for Sveriges nyheter, the Swedish public service TV.
@sebastian-berlin-wmse
Add translator for svt.se 
This is the website for Sveriges nyheter, the Swedish public service TV.
Loading status checks…
4e3209c
@adam3smith

adam3smith reviewed Jul 7, 2018
View changes

Copy link
Collaborator

left a comment

Two additional comments here.
SVT Nyheter.js Outdated
"priority": 100,
"inRepository": true,
"translatorType": 4,
"browserSupport": "gcibv",

This comment has been minimized.

Sign in to view
Copy link
@adam3smith

adam3smith Jul 7, 2018

Collaborator

gcisbv
Show resolved Hide resolved SVT Nyheter.js

@zuphilip zuphilip added the New Translator label Jul 10, 2018

@sebastian-berlin-wmse
Fix translator for svt.se according to code review 
* Updated target regex.
* Added checks to avoid errors when values weren't found.
* Changed `var` to `let` in for loop.
* Added Safari to `browserSupport`.
Loading status checks…
46c9303

@sebastian-berlin-wmse sebastian-berlin-wmse force-pushed the Wikimedia-Sverige:svt-nyheter branch from a3da382 to 46c9303 Aug 13, 2018

@sebastian-berlin-wmse

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Aug 13, 2018

I've updated according to the comments here and in #1691. Let me know if there's anything else.

adam3smith added some commits Sep 6, 2018

@adam3smith
Simplify a bit
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b2a6511
@adam3smith
spacing
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ccf5400
@sebastian-berlin-wmse

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Sep 14, 2018

Is there anything else that needs fixing for this?
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Collaborator

commented Sep 14, 2018

I don't think so, I'm just getting through reviews slowly, sorry.

@adam3smith adam3smith merged commit a08b22e into zotero:master Sep 15, 2018
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Collaborator

commented Sep 15, 2018

Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adam3smith adam3smith

Assignees
No one assigned
Labels
New Translator
Projects
None yet
Milestone
No milestone
3 participants
@sebastian-berlin-wmse @adam3smith @zuphilip
You can’t perform that action at this time.