Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign up:art: Spaces around keywords #1717
+3,003
−3,003
Conversation
zuphilip
requested a review
from adam3smith
Aug 19, 2018
adam3smith
merged commit 2d3e4bd
into
zotero:master
Aug 20, 2018
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
This comment has been minimized.
This comment has been minimized.
|
Thanks! |
zuphilip
deleted the
zuphilip:keyword-spacing
branch
Aug 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
zuphilip commentedAug 19, 2018
Search and replace some cases to add spaces around
keywords: if, else, for, while, switch.
(Excluding FW code and translators with an open pull request.)