Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upFix if condition in Code4Lib Journal translator #1721
Conversation
bencomp
added some commits
Aug 23, 2018
bencomp
referenced this pull request
Aug 23, 2018
Closed
MARCXML import breaks when a subfield is empty #1722
adam3smith
merged commit f14dbb7
into
zotero:master
Aug 24, 2018
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
This comment has been minimized.
This comment has been minimized.
|
Thanks! I'm surprised our tests didn't catch that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
bencomp commentedAug 23, 2018
Due to a missing
)in a condition statement, the Code4Lib Journal translator could not be injected.