/translators

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrape also books in beck-online #1739

Merged
merged 2 commits into from Sep 8, 2018

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@zuphilip @adam3smith
@zuphilip

@zuphilip zuphilip referenced this pull request Sep 8, 2018

Closed

beck-online does not seem to work for kommentar #1738

@adam3smith
Change variable name to avoid confusion 
Since the variable can be either authors or editors, "editors" doesn't seem like a good name.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
2e6cf4c
@adam3smith

This comment has been minimized.

Show comment
Hide comment
@adam3smith

adam3smith Sep 8, 2018

Collaborator

Looks good to me. See if you're OK with my above change, then go ahead & merge. And if you're in a really good mood, see if you can review my SD PR ;) #1733
Collaborator

adam3smith commented Sep 8, 2018

Looks good to me. See if you're OK with my above change, then go ahead & merge. And if you're in a really good mood, see if you can review my SD PR ;) #1733
beck-online.js
var creators = doc.querySelectorAll('#titelseitetext .tpauthor');
for (let creator of creators) {
creator = authorRemoveTitlesEtc(creator.textContent);
item.creators.push(ZU.cleanAuthor(creator, creatorType));

This comment has been minimized.

Show comment
Hide comment
@zuphilip

zuphilip Sep 8, 2018

Collaborator

Ah, yes, that is good. I also thought about it, but then forgot to change in the end. BTW I didn't have an example for the author case and most (all?) books form beck-online might be edited.
Copy URL
@zuphilip

zuphilip Sep 8, 2018

Collaborator

Ah, yes, that is good. I also thought about it, but then forgot to change in the end. BTW I didn't have an example for the author case and most (all?) books form beck-online might be edited.

@zuphilip zuphilip merged commit bd00002 into zotero:master Sep 8, 2018
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zuphilip zuphilip deleted the zuphilip:beck-online-books branch Sep 8, 2018

@zuphilip

This comment has been minimized.

Show comment
Hide comment
@zuphilip

zuphilip Sep 8, 2018

Collaborator

Thank you @adam3smith !
Collaborator

zuphilip commented Sep 8, 2018

Thank you @adam3smith !
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment