Skip to content

/translators

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix semantic scholar translator #1744

Merged
merged 1 commit into from Sep 13, 2018
+126 −156

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@GuyAglionby @adam3smith
@GuyAglionby
Copy link
Contributor

GuyAglionby commented Sep 11, 2018

The semantic scholar website has changed a bit, breaking the xpaths in the translator. Summary of changes:

  • Fix BibTeX xPath
  • They now call "tags" "entities", so amended for this
  • Updated tests accordingly (some of the other data on the website also changed, which the new tests reflect)
  • Removed test which had incorrectly parsed data on their side (link to paper, see authors Jürgen Weiner. Benno Stein conflated)
  • Removed fix for BibTeX export having a bracket mismatch -- this is fixed on their end now.

Thanks!
@GuyAglionby
Fix semantic scholar translator
Verified
This commit was signed with a verified signature.
@GuyAglionby GuyAglionby Guy Aglionby
GPG key ID: 65A11B40BDE7B9B1 Learn about signing commits
Loading status checks…
2f4e361

@adam3smith adam3smith merged commit 6f3b518 into zotero:master Sep 13, 2018
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Collaborator

adam3smith commented Sep 13, 2018

Perfect. Too bad they're no longer putting full first names in the author data.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.