Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate neural information processing systems #1747
Conversation
GuyAglionby
and others
added some commits
Sep 17, 2018
This comment has been minimized.
This comment has been minimized.
just to explain these changes: adding attachments by using the current document doesn't check for mimeType, so I think this would have imported two PDFs on the PDF page (and it definitely wouldn't have gotten the Snapshot of the item page, producing inconsistent behavior). Instead I'm distinguishing between the two cases in the attachment behavior. |
adam3smith
merged commit 9a431bc
into
zotero:master
Sep 28, 2018
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
This comment has been minimized.
This comment has been minimized.
Thanks! |
This comment has been minimized.
This comment has been minimized.
Makes sense -- thanks for the catch :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
GuyAglionby commentedSep 17, 2018
Thanks!