Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update neural information processing systems #1747

Merged
merged 2 commits into from Sep 28, 2018

Conversation

@GuyAglionby
Copy link
Contributor

commented Sep 17, 2018

  • Amended target regex -- books.nips.cc doesn't seem to be used
  • Support saving from author pages
  • Support saving from search results
  • Support saving from pdf

Thanks!

GuyAglionby and others added some commits Sep 17, 2018

@adam3smith

This comment has been minimized.

Copy link
Collaborator

commented Sep 28, 2018

just to explain these changes: adding attachments by using the current document doesn't check for mimeType, so I think this would have imported two PDFs on the PDF page (and it definitely wouldn't have gotten the Snapshot of the item page, producing inconsistent behavior). Instead I'm distinguishing between the two cases in the attachment behavior.

@adam3smith adam3smith merged commit 9a431bc into zotero:master Sep 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Copy link
Collaborator

commented Sep 28, 2018

Thanks!

@GuyAglionby

This comment has been minimized.

Copy link
Contributor Author

commented Sep 28, 2018

Makes sense -- thanks for the catch :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.