Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding some contribution types for me #243

Merged
merged 2 commits into from Jul 1, 2020
Merged

adding some contribution types for me #243

merged 2 commits into from Jul 1, 2020

Conversation

@danielskatz
Copy link
Collaborator

danielskatz commented Jul 1, 2020

Description

Motivation and Context

Checklist:

  • I have posted the link for the PR in the usrse slack (#website) to ask for reviewers
  • I have previewed changes locally
  • I have updated the CHANGELOG and (if necessary) the README.md

cc @usrse-maintainers

@vsoch
Copy link
Member

vsoch commented Jul 1, 2020

This will be great! I'll pull it locally and update the README.md to render it, since we don't have the automated job to do it yet (I built a container to do it so I don't need to run it locally, because npm, nope!)

Signed-off-by: vsoch <vsochat@stanford.edu>
@vsoch vsoch self-requested a review Jul 1, 2020
@vsoch
vsoch approved these changes Jul 1, 2020
@vsoch
Copy link
Member

vsoch commented Jul 1, 2020

We can merge when it passes! I should add mine too. I'll also remove manbat that's technically me, but it's my bot user.

@danielskatz
Copy link
Collaborator Author

danielskatz commented Jul 1, 2020

Thanks - I was trying to figure out how to preview this, but couldn't find it in the circleci artifacts

@vsoch
Copy link
Member

vsoch commented Jul 1, 2020

Yeah I'll need to automate it, just haven't had time yet. I'm happy to do manual updates for the time being!

@vsoch vsoch merged commit 283522b into master Jul 1, 2020
2 checks passed
2 checks passed
urlcheck
Details
ci/circleci: build-site Your tests passed on CircleCI!
Details
@vsoch vsoch deleted the dsk-contribution-types branch Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.