Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upBuffer Documents for ConcurrentUpdateSolrClient #576
+91
−33
Conversation
r-clancy
added some commits
Feb 10, 2019
r-clancy
requested a review
from
lintool
Feb 11, 2019
lintool
reviewed
Feb 12, 2019
r-clancy
added some commits
Feb 12, 2019
lintool
approved these changes
Feb 13, 2019
lintool
merged commit ca58b56
into
castorini:master
Feb 13, 2019
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
r-clancy commentedFeb 11, 2019
(Re-)add object pooling for SolrClients... it helped throughput quite a bit for
CloudSolrClienteven though it's thread-safe.Also, buffer docs for the
ConcurrentUpdateSolrClientas it's queue is for update requests (i.e., it buffersadd(SolrInputDocument)calls until the queue size is reached then drains the queue concurrently).