Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upRobust links alignment #115
Conversation
shawnmjones
added some commits
Aug 6, 2018
shawnmjones
added
the
enhancement
label
Aug 7, 2018
shawnmjones
self-assigned this
Aug 7, 2018
shawnmjones
merged commit 0e8f812
into
master
Aug 7, 2018
1 check passed
| @@ -122,7 +122,7 @@ On success, the social card service produces an HTTP 200 status response contain | ||
| </p> | ||
| </div> | ||
| </blockquote> | ||
| <script async src="http://mementoembed.ws-dl.cs.odu.edu/static/js/mementoembed.js" charset="utf-8"></script> | ||
| <script async src="http://mementoembed.ws-dl.cs.odu.edu/static/js/mementoembed-v20180806.js" charset="utf-8"></script> |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ibnesayeed
Aug 7, 2018
Member
@shawnmjones if you are using version number in the file name just to avoid any browser caches, then you can use the number as query parameter instead of the file name (i.e., mementoembed.js?v=20180806 instead of mementoembed-v20180806.js). This way, the server will ignore any query parameters when serving a static file and serve whatever version of the file is present with that name, but the browser would be fooled to burst the cache. The reason of this change suggestion is because if you are tracking that file and not generating as the build process then renaming the file on every release would be messy.
ibnesayeed
Aug 7, 2018
Member
@shawnmjones if you are using version number in the file name just to avoid any browser caches, then you can use the number as query parameter instead of the file name (i.e., mementoembed.js?v=20180806 instead of mementoembed-v20180806.js). This way, the server will ignore any query parameters when serving a static file and serve whatever version of the file is present with that name, but the browser would be fooled to burst the cache. The reason of this change suggestion is because if you are tracking that file and not generating as the build process then renaming the file on every release would be messy.
shawnmjones commentedAug 7, 2018
This consists of work for #114. I am leaving #114 open a while for further discussion, if necessary.