Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upUse XML 1.0; resolves #26. #27
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
greebie
Aug 27, 2018
Collaborator
I'll give it a test tomorrow morning. It is not necessary to go to \x0A if we go back to 1.0. But it might save us some Windows compatibility down the road.
|
I'll give it a test tomorrow morning. It is not necessary to go to \x0A if we go back to 1.0. But it might save us some Windows compatibility down the road. |
ianmilligan1
approved these changes
Aug 28, 2018
Tested on previously blank collections and is working well. As seen below, this collection failed with previous graphpass and works with this one.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
greebie
Aug 28, 2018
Collaborator
I got a response to my issue about 1.2 being deprecated: gephi/gexf#11. It seems like the story is just what we think it is. 1.2 is deprecated, but 1.3 is a work in progress.
I may have learned a lesson about reacting to deprecation warnings, assuming that they mean you should upgrade.
I think we should just go back to 1.2. The 1.3 project is looking a little unfocussed. I do not know why they decided to deprecate 1.2.
|
I got a response to my issue about 1.2 being deprecated: gephi/gexf#11. It seems like the story is just what we think it is. 1.2 is deprecated, but 1.3 is a work in progress. I may have learned a lesson about reacting to deprecation warnings, assuming that they mean you should upgrade. I think we should just go back to 1.2. The 1.3 project is looking a little unfocussed. I do not know why they decided to deprecate 1.2. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Should we bump this back down to 1.2 then, or leave it at 1.3? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
greebie
Aug 28, 2018
Collaborator
If Ian is okay with it, I think we should bump down to 1.2. The main changes I see in 1.3 have to do with dynamic graphs and we do not really use those much.
|
If Ian is okay with it, I think we should bump down to 1.2. The main changes I see in 1.3 have to do with dynamic graphs and we do not really use those much. |
ruebot
referenced this pull request
Aug 28, 2018
Open
Remove commented out gexf code; resolves #28. #39
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Let's bump down to 1.2. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Weird. My change isn't showing up here. I'll close and re-open. |
ruebot commentedAug 27, 2018
d17b57c
Testing
I tested this with a few Dalhousie collections. I build GraphPass, and then used in with auk, and analyzed a few collections that were previously displaying empty graphs for me. Things seem to be working fine.
@greebie @ianmilligan1 can you give this a more thorough test when you have some time?