/graphpass

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove commented out gexf code; resolves #28. #39

Closed
wants to merge 2 commits into
base: master
from
+71 −118

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@ruebot
@ruebot
Member

ruebot commented Aug 28, 2018

GitHub issue(s): #28

What does this Pull Request do?

Remove commented out gexf code.

How should this be tested?

Unit test should pass?

Additional Notes:

This should be merged after #27 since I branched off that branch for this branch.

ruebot added some commits Aug 27, 2018

@ruebot
Use XML 1.0; resolves #26. 
- Roll back to XML 1.0 from 1.1 introduced in
d17b57c
- Switch line ending encoding from \n to \x0A
- Clean up whitespace in file
Verified
This commit was signed with a verified signature.
@ruebot ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
d42d477
@ruebot
Remove commented out gexf code; resolves #28.
Verified
This commit was signed with a verified signature.
@ruebot ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
e93a8be
@ruebot

This comment has been minimized.

Show comment
Hide comment
@ruebot

ruebot Aug 28, 2018

Member

Since #27 got weird, I'll close this and create a new one once #41 is merged.
Member

ruebot commented Aug 28, 2018

Since #27 got weird, I'll close this and create a new one once #41 is merged.

@ruebot ruebot closed this Aug 28, 2018

@ruebot ruebot deleted the ruebot:issue-28 branch Aug 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment