Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upTranslator for theses.fr #1645
Conversation
TesteFixe
changed the title
Add a translator for theses.fr
Translator for theses.fr
May 15, 2018
adam3smith
requested changes
Aug 12, 2018
|
Sorry for the delay. I have a couple of small questions & change requests, but my biggest concern is that the site isn't working for me at all (all thesis links like http://www.theses.fr/s197772 just link back to the search screen)-- is it broken or is access gated? |
| ], | ||
| "tags": [ | ||
| { | ||
| "tag": "RGD Chitosan Nanoparticles Cell adhesion Wound healing" |
This comment has been minimized.
This comment has been minimized.
adam3smith
Aug 12, 2018
Collaborator
These don't look right. These are multiple tags. Maybe split on capital letter?
| translator.setHandler('itemDone', function(obj, item) { | ||
| //add type | ||
| //converting internal info:eu-repo/semantics/doctoralThesis notation to "Ph.D. Thesis" only for collections and items | ||
| if (item.url.indexOf("/handle/") > -1) { |
This comment has been minimized.
This comment has been minimized.
|
|
||
| function detectWeb(doc, url) { | ||
|
|
||
| if (url.indexOf("?q=") != -1) { |
This comment has been minimized.
This comment has been minimized.
|
|
||
| if (url.indexOf("?q=") != -1) { | ||
| return "multiple"; | ||
| } else if (url.indexOf("?q=") == -1) { |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
adam3smith
Aug 12, 2018
Collaborator
also, take advantage of checkSearchResults below and use that here to avoid false positives.
This comment has been minimized.
This comment has been minimized.
TesteFixe
Aug 16, 2018
Author
Contributor
Hi,
Theses.fr is Ok : link works : http://www.theses.fr/s197772
Thanks a lot for your reviewing : i'll make the changes asap!
This comment has been minimized.
This comment has been minimized.
adam3smith
added
the
waiting
label
Aug 12, 2018
This comment has been minimized.
This comment has been minimized.
|
Hi @adam3smith, do you still have this issue ? Right now if I follow the link you gave, I can see a detailed record : |
adam3smith
removed
the
waiting
label
Aug 24, 2018
This comment has been minimized.
This comment has been minimized.
|
@symac working now -- I believe the issue wasn't just for me |
This comment has been minimized.
This comment has been minimized.
|
Thanks a lot!! |
adam3smith
merged commit 35475a9
into
zotero:master
Sep 10, 2018
1 check passed
This comment has been minimized.
This comment has been minimized.
|
Thanks! |
TesteFixe commentedMay 4, 2018
A new translator for http://theses.fr, institutional repository of french doctoral thesis