Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upadded theses.fr webtranslator #1672
Conversation
pirpyn
and others
added some commits
Jun 8, 2018
adam3smith
requested changes
Aug 12, 2018
Some questions/comments in line. Biggest concern is though that this simply doesn't work for me -- is the site access restricted or is it currently broken? Links like
http://www.theses.fr/s197772
just take me to the empty search screen.
| "translatorID": "65c7ee26-eee7-442a-ba09-41da30cf2864", | ||
| "label": "Theses.fr", | ||
| "creator": "Pierre Payen", | ||
| "target": "^https?://(www\\.)?theses.fr/[^?]", |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
| // translator.setDocument(doc); | ||
| translator.setHandler('itemDone', function (obj, item) { | ||
| item.section = "Theses"; |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
adam3smith
Aug 12, 2018
Collaborator
that's not part of the Zotero thesis item type. What are you trying to do here?
adam3smith
Aug 12, 2018
Collaborator
that's not part of the Zotero thesis item type. What are you trying to do here?
| function scrape(doc, url) { | ||
| var translator = Zotero.loadTranslator('web'); | ||
| translator.setTranslator('951c027d-74ac-47d4-a107-9c3069ab7b48'); | ||
| // translator.setDocument(doc); |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
| "creatorType": "author" | ||
| } | ||
| ], | ||
| "abstractNote": ",", |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
adam3smith
Aug 12, 2018
Collaborator
That's no good. Clean empty abstracts up. Also, we really don't have a better place to get this than the Twitter description?
adam3smith
Aug 12, 2018
Collaborator
That's no good. Clean empty abstracts up. Also, we really don't have a better place to get this than the Twitter description?
| ], | ||
| "tags": [ | ||
| { | ||
| "tag": "en français" |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
| ], | ||
| "tags": [ | ||
| { | ||
| "tag": "Stratégie de potentialisation Tuberculose Ethionamide Isoniazide Multi-résistance en français" |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
adam3smith
Aug 12, 2018
Collaborator
These tags look good, but need to be properly separated out to be useful. Is there no place the tags are listed more systematically?
adam3smith
Aug 12, 2018
Collaborator
These tags look good, but need to be properly separated out to be useful. Is there no place the tags are listed more systematically?
adam3smith
added
waiting
and removed
waiting
labels
Aug 12, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
adam3smith
Aug 12, 2018
Collaborator
actually, never mind. This is a duplicate of #1645 , which looks in better shape
|
actually, never mind. This is a duplicate of #1645 , which looks in better shape |
pirpyn commentedJun 8, 2018
First version of the web translator for https://theses.fr