Track tasks and feature requests
Join 36 million developers who use GitHub issues to help identify, assign, and keep track of the features and bug fixes your projects need.
Sign up for free See pricing for teams and enterprises[REVIEW]: VIVO: a system for research discovery #1182
Comments
whedon
assigned
jasonclark
Jan 16, 2019
whedon
added
the
review
label
Jan 16, 2019
whedon
referenced this issue
Jan 16, 2019
Closed
[PRE REVIEW]: VIVO: a system for research discovery #943
This comment has been minimized.
This comment has been minimized.
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @sonal-raj it looks like you're currently assigned as the reviewer for this paper If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews To fix this do the following two things:
For a list of things I can do to help you, just type:
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jasonclark
commented
Jan 17, 2019
@sonal-raj Thanks for making time for this review later this month. I/We appreciate it. Checklist and instructions are above. Let me know if schedules change. Hope the conference goes well. cc @mconlon17 |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
@labarba - I am done with most of the review. I will update it by this weekend. Apologies for the delay, been drowning in work of late! |
This comment has been minimized.
This comment has been minimized.
The VIVO software has been reviewed against all the recommended criteria in the checklist. The installation, functionality and documentation are sound and the current version is operational without issues. I recommend the acceptance of this submission. |
This comment has been minimized.
This comment has been minimized.
@jasonclark — this one is ready for your final checks. |
This comment has been minimized.
This comment has been minimized.
jasonclark
commented
Apr 5, 2019
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jasonclark
commented
Apr 5, 2019
Hi, @mconlon17. We are close to finishing this paper. There is a final step where you make an archive of the software in Zenodo and report the DOI. Can you do that and let me know the DOI here? |
This comment has been minimized.
This comment has been minimized.
mconlon17
commented
Apr 5, 2019
Very good to hear. Will do. |
This comment has been minimized.
This comment has been minimized.
mconlon17
commented
Apr 14, 2019
Here is the DOI: https://doi.org/10.5281/zenodo.2639713 |
This comment has been minimized.
This comment has been minimized.
@mconlon17 - there are a couple of issues with your paper. One of the grant numbers looks to be a placeholder ( Also, none of the references are included in the body text which means they won't be compiled into the paper pdf. You can read how to do that here. |
whedon
assigned
sonal-raj
May 6, 2019
This comment has been minimized.
This comment has been minimized.
danielskatz
commented
May 20, 2019
|
This comment has been minimized.
This comment has been minimized.
I should have updated here to say I emailed the author last night about this and he replied immediately. I would expect an update shortly. |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
I've just sent @mconlon17 another reminder over email. |
This comment has been minimized.
This comment has been minimized.
kyleniemeyer
commented
Jul 1, 2019
Hi @mconlon17, just checking in about your updates to the paper. |
This comment has been minimized.
This comment has been minimized.
danielskatz
commented
Jul 13, 2019
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
hauschke
commented
Jul 15, 2019
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
PDF failed to compile for issue #1182 with the following error: Error reading bibliography ./paper.bib (line 33, column 9): |
Jul 15, 2019
This was referenced
This comment has been minimized.
This comment has been minimized.
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
PDF failed to compile for issue #1182 with the following error: Error reading bibliography ./paper.bib (line 33, column 9): |
This comment has been minimized.
This comment has been minimized.
@mconlon17 - this PR should allow your paper to compile: vivo-project/VIVO#134 |
This comment has been minimized.
This comment has been minimized.
danielskatz
commented
Jul 18, 2019
|
whedon commentedJan 16, 2019
•
edited by sonal-raj
Submitting author: @mconlon17 (Michael Conlon)
Repository: https://github.com/vivo-project/VIVO
Version: v1.10.0
Editor: @jasonclark
Reviewer: @sonal-raj
Archive: Pending
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@sonal-raj, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @jasonclark know.
Review checklist for @sonal-raj
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?