Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upPaper revision #131
Conversation
hauschke
added some commits
Jul 8, 2019
hauschke
changed the title
Patch 2
Paper revision
Jul 8, 2019
This comment has been minimized.
This comment has been minimized.
|
Can you have a look, @mconlon17? |
This comment has been minimized.
This comment has been minimized.
danielskatz
commented
Jul 12, 2019
|
note that the JOSS paper seems to be stuck, waiting for changes for @mconlon17 that were requested 15 April |
This comment has been minimized.
This comment has been minimized.
|
I was trying to address these change requests. If someone could check the changes and (if okay) merge, we could get this off the table. It would be really nice to have a citable reference for VIVO itself. |
awoods
reviewed
Jul 12, 2019
| discovery, expert finding, network analysis and assessment of research impact. | ||
| VIVO is easily extended to support additional domains of scholarly activity. | ||
| discovery, expert finding, network analysis and assessment of research impact. | ||
| VIVO is easily extended to support additional domains of scholarly activity [@borner_vivo:_2012]. |
This comment has been minimized.
This comment has been minimized.
awoods
Jul 12, 2019
Member
These [@xxx] references do not appear to resolve as links. @hauschke , were you expecting a different behavior?
This comment has been minimized.
This comment has been minimized.
awoods
Jul 12, 2019
Member
Although you appear to be aligned with the recommendation:
https://rmarkdown.rstudio.com/authoring_bibliographies_and_citations.html
@hauschke , as far as you know, is there any way of testing the references?
This comment has been minimized.
This comment has been minimized.
danielskatz
Jul 12, 2019
•
to test, change the .md or .bib, then put a comment in the review issue with @whedon generate pdf - editors and authors can do this, which might be an issue here.
This comment has been minimized.
This comment has been minimized.
awoods
Jul 12, 2019
Member
@danielskatz : I am not sure I follow your suggestion. Can you re-articulate what you are saying?
This comment has been minimized.
This comment has been minimized.
danielskatz
Jul 12, 2019
To regenerate the PDF (to test changes made in the .md and .bib files), in openjournals/joss-reviews#1182 an editor or the author can put a new comment in that contains @whedon generate pdf - this will tell @whedon to regenerate the PDF from the md and bib.
awoods
approved these changes
Jul 12, 2019
hudajkhan
merged commit abc152c
into
vivo-project:develop
Jul 13, 2019
1 check passed
This comment has been minimized.
This comment has been minimized.
danielskatz
commented
Jul 13, 2019
|
The new version of the paper is https://github.com/openjournals/joss-papers/blob/joss.01182/joss.01182/10.21105.joss.01182.pdf |
hauschke commentedJul 8, 2019
•
edited
** Added references to JOSS paper and edited acknowledgements.
Related to: openjournals/joss-reviews#1182
What does this pull request do?
Fixing some issued from the paper review process.
What's new?
References in the paper itself.
Interested parties
@mconlon17