Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output_filename is a variable as currently written #16

Closed
ruebot opened this Issue Mar 3, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@ruebot
Copy link
Member

ruebot commented Mar 3, 2019

This example in the "Text Analysis" section will fail if uncomment as directed because output_filename is an undefined variable, not a string.

## Removing the # on the following line will write the results to a file entitled `output_filename`

#write_output(output_filename, year_results)
---------------------------------------------------------------------------
NameError                                 Traceback (most recent call last)
<ipython-input-9-6bd5d6cf343c> in <module>
      8 ## Removing the # on the following line will write the results to a file entitled `output_filename`
      9 
---> 10 write_output(output_filename, year_results)

NameError: name 'output_filename' is not defined

Maybe we should change it to this?

## Removing the # on the following line will write the results to a file entitled `filtered.txt`

#write_output('filtered.txt', year_results)

We probably should add instructions to make it write to a VOLUME or -v mount with Docker too?

@ruebot ruebot added the bug label Mar 3, 2019

@ruebot ruebot self-assigned this Mar 3, 2019

ruebot added a commit that referenced this issue Mar 4, 2019

ruebot added a commit that referenced this issue Mar 5, 2019

ianmilligan1 added a commit that referenced this issue Mar 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.