Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upFix case, and actually resolve #16. #21
Conversation
ruebot
requested review from
greebie
and
ianmilligan1
Mar 5, 2019
greebie
approved these changes
Mar 5, 2019
This comment has been minimized.
This comment has been minimized.
|
This one was my bad. I was sure I had a var there, but then I assumed I deleted it for a reason. I think the var is a better idea, just in case someone ends up creating additional scripts and wants to change all them at once. |
ianmilligan1
approved these changes
Mar 5, 2019
ianmilligan1
merged commit 9af6509
into
master
Mar 5, 2019
1 check passed
ci/dockercloud
Your tests passed in Docker Cloud
Details
ianmilligan1
deleted the
issue-16-b
branch
Mar 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ruebot commentedMar 5, 2019
See: #18 (comment)