/aut

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

class LanguageIdentifier in package language is deprecated #126

Closed
ruebot opened this Issue Nov 30, 2017 · 6 comments

Comments

Assignees

@ianmilligan1 ianmilligan1

Labels
None yet
Projects
  
Done in 1.0.0 Release of AUT
Milestone
No milestone
2 participants
@ruebot @ianmilligan1
@ruebot
Member

ruebot commented Nov 30, 2017 

[WARNING] /home/nruest/git/aut/src/main/scala/io/archivesunleashed/spark/matchbox/DetectLanguage.scala:24: warning: class LanguageIdentifier in package language is deprecated: see corresponding Javadoc for more information.
[INFO]     else new LanguageIdentifier(input).getLanguage
[INFO]              ^
[WARNING] one warning found

@ruebot ruebot added this to In Progress in 1.0.0 Release of AUT Nov 30, 2017

@ianmilligan1

This comment has been minimized.

Sign in to view
Member

ianmilligan1 commented Nov 30, 2017

Looking into this. Was replaced by LanguageDetector: https://tika.apache.org/1.15/api/org/apache/tika/language/detect/LanguageDetector.html

@ianmilligan1 ianmilligan1 self-assigned this Nov 30, 2017

@ianmilligan1

This comment has been minimized.

Sign in to view
Member

ianmilligan1 commented Nov 30, 2017

Yeah, so turns out even to do something as seemingly straightforward as swapping out LanguageIdentifier for LanugageDetector requires that I know something about Java, which I know nothing. If I can find time I will try to do this, but it'll take me hours. The Tika docs aren't intuitive to me.
@ruebot

This comment has been minimized.

Sign in to view
Member

ruebot commented Nov 30, 2017

I've tried to swap it out with this: https://tika.apache.org/1.16/api/org/apache/tika/parser/txt/CharsetMatch.html#getLanguage-- but, that isn't working I thought it would.

Easy solution is to just go back to the version we were using before.
@ianmilligan1

This comment has been minimized.

Sign in to view
Member

ianmilligan1 commented Nov 30, 2017

At least we ended up on the same man page.

Yes, let's go back to the version we were using before if we can.
@ruebot

This comment has been minimized.

Sign in to view
Member

ruebot commented Nov 30, 2017

Those are Java docs. The URI you were looking at is for 1.15. We're at 1.16.

Looks like the new functionality was added in 1.13. I'll put a PR in to take us back down to 1.12.
@ianmilligan1

This comment has been minimized.

Sign in to view
Member

ianmilligan1 commented Nov 30, 2017

Great, thanks Nick. Maybe I'll ask Santa for a Java for Dummies book.

ruebot added a commit that referenced this issue Nov 30, 2017

@ruebot
Downgrade Tika to 1.12. Resolves #126.
Verified
This commit was signed with a verified signature.
@ruebot ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
Loading status checks…
6959d8a

This was referenced Nov 30, 2017

Closed
Merged

@ianmilligan1 ianmilligan1 closed this in 7dbe5ec Nov 30, 2017

@ruebot ruebot moved this from In Progress to Done in 1.0.0 Release of AUT Nov 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment