Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upDowngrade Tika to 1.12. Resolves #126. #132
Conversation
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Nov 30, 2017
•
Codecov Report
@@ Coverage Diff @@
## master #132 +/- ##
======================================
Coverage 65.6% 65.6%
======================================
Files 36 36
Lines 721 721
Branches 140 140
======================================
Hits 473 473
Misses 199 199
Partials 49 49Continue to review full report at Codecov.
|
ianmilligan1
approved these changes
Nov 30, 2017
Looks great to me – verified that depreciation warning isn't appearing on the builds.
ianmilligan1
merged commit 7dbe5ec
into
master
Nov 30, 2017
4 checks passed
ianmilligan1
deleted the
issue-126
branch
Nov 30, 2017
ruebot
added this to Done
in 1.0.0 Release of AUT
Nov 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ruebot commentedNov 30, 2017
GitHub issue(s): 126
What does this Pull Request do?
Moves us down to Tika 1.12. 1.13+ deprecates how we
DetectLanguage.Enhancement ticket for this. We can get to it when we can.
How should this be tested?
Checkout the TravisCI build log and make sure you don't see the deprecation notice we were seeing in #126.