Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: Open-Unmix - A Reference Implementation for Music Source Separation #1659

Open
whedon opened this issue Aug 18, 2019 · 16 comments

Comments

@whedon
Copy link
Collaborator

commented Aug 18, 2019

Submitting author: @faroit (Fabian-Robert Stöter)
Repository: https://github.com/sigsep/open-unmix-paper-joss
Version: v1.0.0
Editor: Pending
Reviewer: Pending

Author instructions

Thanks for submitting your paper to JOSS @faroit. Currently, there isn't an JOSS editor assigned to your paper.

@faroit if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands

@whedon whedon added the pre-review label Aug 18, 2019

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 18, 2019

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience 😸

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 18, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 18, 2019

Failed to discover a valid open source license.

@whedon whedon added the TeX label Aug 18, 2019

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 18, 2019

PDF failed to compile for issue #1659 with the following error:

/app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-80a4e9edb5a6/lib/whedon.rb:143:in block in check_orcids': Problem with ORCID (0000-0000-0000-0000) for Stefan Uhlich (RuntimeError) from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-80a4e9edb5a6/lib/whedon.rb:141:in each'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-80a4e9edb5a6/lib/whedon.rb:141:in check_orcids' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-80a4e9edb5a6/lib/whedon.rb:88:in initialize'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-80a4e9edb5a6/lib/whedon/processor.rb:36:in new' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-80a4e9edb5a6/lib/whedon/processor.rb:36:in set_paper'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-80a4e9edb5a6/bin/whedon:55:in prepare' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/command.rb:27:in run'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in invoke_command' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor.rb:387:in dispatch'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/base.rb:466:in start' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-80a4e9edb5a6/bin/whedon:116:in <top (required)>'
from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in

'

@danielskatz

This comment has been minimized.

Copy link

commented Aug 18, 2019

Please merge sigsep/open-unmix-paper-joss#1 and see if that enables the paper to build by entering @whedon generate pdf as a new comment here. (also note that I suggested a number of language changes as well in the PR - these are all optional...

@danielskatz

This comment has been minimized.

Copy link

commented Aug 18, 2019

👋 @arokem - would you be willing to edit this submission?

@faroit

This comment has been minimized.

Copy link

commented Aug 18, 2019

@whedon generate pdf

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 18, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 18, 2019

@faroit

This comment has been minimized.

Copy link

commented Aug 18, 2019

@danielskatz regarding the use of submodules, please note my questions I asked earlier in JOSS#565.

@danielskatz

This comment has been minimized.

Copy link

commented Aug 18, 2019

Thanks for pointing that out - please also mention it in the review thread that will be created once there are an editor and reviewers assigned.

@danielskatz

This comment has been minimized.

Copy link

commented Aug 18, 2019

Also, while we wait for that, you might want to make some fixes in the bib part of the paper - anything in a title or booktitle that should be in Upper Case needs to be protected with {}s, for example
booktitle={Proc. {IEEE} Intl. Conf. on Acoustics, Speech and Signal Processing (ICASSP)},
could be
booktitle={{Proc. IEEE Intl. Conf. on Acoustics, Speech and Signal Processing (ICASSP)}},
to preserve all cases, or you could manually select parts to preserve, noting that the "." triggers automatic capitalization of the following word...

Another example is
title = {MUSDB18-HQ - an uncompressed version of MUSDB18},
which could be
title = {{MUSDB18-HQ} - an uncompressed version of {MUSDB18}},
or
title = {{MUSDB18-HQ - an uncompressed version of MUSDB18}},

@faroit

This comment has been minimized.

Copy link

commented Aug 18, 2019

Also, while we wait for that, you might want to make some fixes in the bib part of the paper

sure, will do.

Another question: can you please point me to JOSSs pre-print policy? E.g. can I simultaneously submit to arxiv?

@danielskatz

This comment has been minimized.

Copy link

commented Aug 18, 2019

This is fine, although it's a little unusual - JOSS papers are usually short and focus on the software itself, while authors often write longer papers about the use of the software, for journals or conferences, and those longer papers are the ones that are usually submitted as pre-prints.

@faroit

This comment has been minimized.

Copy link

commented Aug 19, 2019

This is fine, although it's a little unusual - JOSS papers are usually short and focus on the software itself, while authors often write longer papers about the use of the software, for journals or conferences, and those longer papers are the ones that are usually submitted as pre-prints.

maybe our contribution is a bit unusual here, indeed. We actually wrote the paper to be significanlty longer, describing the technical details of the model (see arxiv branch) and then shortened it to <2000 words to comply with the JOSS policy.
Since there are not many scientific contributions being made – the model is basically the distillation of multiple former methods, we therefore, really would like to stick to a JOSS-only contribution for now and will probably write a longer journal later this year, that include larger scale experiments, hence a more rigor scientific contribution.

Now, we still want to offer a DOI for the community as quickly as possible, because we expect them to cite this paper very soon with the upcoming deadlines of the major conferences in our field.

@danielskatz

This comment has been minimized.

Copy link

commented Aug 19, 2019

Ok, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.