Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upfixes to build and for language #1
+25
−26
Conversation
danielskatz
referenced this pull request
Aug 18, 2019
Open
[PRE REVIEW]: Open-Unmix - A Reference Implementation for Music Source Separation #1659
faroit
approved these changes
Aug 18, 2019
Thanks a lot for the corrections! |
This comment has been minimized.
This comment has been minimized.
@danielskatz I added the ORCID IDs from the other authors. |
faroit
merged commit a4cea56
into
sigsep:master
Aug 18, 2019
danielskatz
deleted the
danielskatz:patch-1
branch
Aug 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
danielskatz commentedAug 18, 2019
for people without orcids, just remove the orcid part of the metadata...