New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix python2-isms and pylint warnings #5

Merged
merged 3 commits into from Nov 12, 2018

Conversation

Projects
None yet
2 participants
@kba
Contributor

kba commented Nov 6, 2018

This makes bagit-profiles-validator py3-compatible and fixes a few warnings, reduces the number of unreachable code etc. No functional changes.

Is this still maintained? Is there an exchange between this and https://github.com/fair-research/bdbag/blob/master/bdbag/bdbagit_profile.py?

@ruebot

This comment has been minimized.

Collaborator

ruebot commented Nov 6, 2018

Hi @kba, thanks!

This is still maintained for the most part. @mjordan and I are around, but there isn't much active development happening.

Can't say there is any exchange between that project and ours. First I've honestly heard about it.

@ruebot

This comment has been minimized.

Collaborator

ruebot commented Nov 6, 2018

[nruest@wombat:bagit-profiles-validator] (git)-[2to3]-$ python3 setup.py test                              
running test
running egg_info
writing bagit_profile.egg-info/PKG-INFO
writing dependency_links to bagit_profile.egg-info/dependency_links.txt
writing requirements to bagit_profile.egg-info/requires.txt
writing top-level names to bagit_profile.egg-info/top_level.txt
reading manifest file 'bagit_profile.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'bagit_profile.egg-info/SOURCES.txt'
running build_ext
test_validate (test.Test_bag_profile) ... /usr/local/lib/python3.6/dist-packages/bagit-1.7.0-py3.6.egg/bagit.py:320: DeprecationWarning: Use the Bag.version_info tuple instead of Bag.version
  DeprecationWarning,
ok
test_validate_accept_bagit_version (test.Test_bag_profile) ... ok
test_validate_allow_fetch (test.Test_bag_profile) ... ok
test_validate_bag_info (test.Test_bag_profile) ... ok
test_validate_bagit_profile_info (test.Test_bag_profile) ... ok
test_validate_manifests_required (test.Test_bag_profile) ... ok
test_validate_serialization (test.Test_bag_profile) ... ok

----------------------------------------------------------------------
Ran 7 tests in 2.123s

OK

Looks good to me. Let me know if you're good with this @mjordan, and I can merge.

I suppose we should setup TravisCI or CircleCI on this.

@kba

This comment has been minimized.

Contributor

kba commented Nov 6, 2018

Cool, thanks, appreciate the quick response!

I suppose we should setup TravisCI or CircleCI on this.

Just now preparing a .circleci/config.yml :) PR in a few minutes.

@ruebot

This comment has been minimized.

Collaborator

ruebot commented Nov 6, 2018

Thanks! I've authorized CircleCI for this GitHub org, so we should be good to go there once we get the other PR in and merged.

@ruebot

This comment has been minimized.

Collaborator

ruebot commented Nov 6, 2018

@kba want to update this branch, and hopefully it should trigger the build?

@kba

This comment has been minimized.

Contributor

kba commented Nov 7, 2018

Fixed the urlopen/python3-bytes-are-not-str problems, tests pass now.

@kba kba referenced this pull request Nov 7, 2018

Merged

Pass profile to constructor #7

@kba kba referenced this pull request Nov 7, 2018

Closed

Version deprecated #9

@ruebot ruebot requested a review from mjordan Nov 7, 2018

@ruebot

ruebot approved these changes Nov 7, 2018

@kba kba referenced this pull request Nov 9, 2018

Merged

Lint #11

@ruebot

This comment has been minimized.

Collaborator

ruebot commented Nov 12, 2018

@mjordan you ok if I merge this one, and start moving on to the other PRs?

@ruebot ruebot merged commit 24048d5 into bagit-profiles:master Nov 12, 2018

5 checks passed

ci/circleci: build-python27 Your tests passed on CircleCI!
Details
ci/circleci: build-python34 Your tests passed on CircleCI!
Details
ci/circleci: build-python35 Your tests passed on CircleCI!
Details
ci/circleci: build-python36 Your tests passed on CircleCI!
Details
ci/circleci: build-python37 Your tests passed on CircleCI!
Details

@kba kba deleted the kba:2to3 branch Nov 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment