Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upfix python2-isms and pylint warnings #5
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Looks good to me. Let me know if you're good with this @mjordan, and I can merge. I suppose we should setup TravisCI or CircleCI on this. |
This comment has been minimized.
This comment has been minimized.
Cool, thanks, appreciate the quick response!
Just now preparing a |
This comment has been minimized.
This comment has been minimized.
Thanks! I've authorized CircleCI for this GitHub org, so we should be good to go there once we get the other PR in and merged. |
kba
referenced this pull request
Nov 6, 2018
Merged
add circle ci config, badge to pypi/ci in readme #6
This comment has been minimized.
This comment has been minimized.
@kba want to update this branch, and hopefully it should trigger the build? |
This comment has been minimized.
This comment has been minimized.
Fixed the |
kba
added some commits
Nov 6, 2018
ruebot
requested a review
from
mjordan
Nov 7, 2018
This comment has been minimized.
This comment has been minimized.
@mjordan you ok if I merge this one, and start moving on to the other PRs? |
kba commentedNov 6, 2018
This makes bagit-profiles-validator py3-compatible and fixes a few warnings, reduces the number of unreachable code etc. No functional changes.
Is this still maintained? Is there an exchange between this and https://github.com/fair-research/bdbag/blob/master/bdbag/bdbagit_profile.py?