Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upadd circle ci config, badge to pypi/ci in readme #6
+59
−11
Conversation
kba
changed the title from
:construction_worker: add circle ci config, badge to pypi/ci in readme
to
add circle ci config, badge to pypi/ci in readme
Nov 6, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
Thanks @kba! |
ruebot
merged commit ed752e3
into
bagit-profiles:master
Nov 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
kba commentedNov 6, 2018
Test against 2.7 and 3.{4,5,6,7} by running
test.pyandmodule_test.pyscript.Fails currently for 3.*: https://circleci.com/gh/kba/bagit-profiles-validator/tree/circleci
With #5 merged fails succeeds for 3.6 and 3.7 but fails for the rest: https://circleci.com/gh/kba/bagit-profiles-validator/tree/circleci-2to3
The joy. But it's fixable with a conditional import from urllib.