Skip to content

/ aut

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve TupleFormatter.scala test coverage #59

Closed
ruebot opened this issue Oct 2, 2017 · 3 comments
Closed

Improve TupleFormatter.scala test coverage #59

ruebot opened this issue Oct 2, 2017 · 3 comments
Assignees
@greebie
Labels
RA-Task tests
Projects
Test coverage

Comments

@ruebot
Copy link
Member

@ruebot ruebot commented Oct 2, 2017 •
edited

TupleFormatter.scala test coverage can be improved.
@ruebot ruebot added the tests label Oct 2, 2017
@ruebot ruebot added this to To Do in Test coverage Oct 2, 2017
@greebie greebie self-assigned this Oct 4, 2017
@greebie greebie mentioned this issue Oct 4, 2017
Merged
@greebie greebie closed this Oct 4, 2017
@greebie greebie reopened this Oct 4, 2017
@ruebot
Copy link
Member Author

@ruebot ruebot commented Oct 5, 2017 •
edited

Couple more lines to cover here that #84 did not cover:
https://codecov.io/gh/archivesunleashed/aut/src/master/src/main/scala/io/archivesunleashed/spark/matchbox/TupleFormatter.scala
greebie added a commit that referenced this issue Oct 5, 2017
@greebie
Issues #56, #57, #58, #59, #61, #62
Loading status checks…
200bb9b
@greebie greebie mentioned this issue Oct 6, 2017
Merged
ruebot added a commit that referenced this issue Oct 6, 2017
@greebie @ruebot
Improve Test Coverage for #55, #56, #57, #58, #59, #60, #61, #62, #63, …
Loading status checks…
c8b7d2e 
…#64 & #66 (#87)

* Add tests for remove Tuples, CreateGDF and RemoveHTML

* Add RemoveHttpHeader test.

* Add license header to tests.

* Issues #56, #57, #58, #59, #61, #62

* resolves Issue #85 (JsonUtil)

* Fix issue # 64 (ExtractDate coverage)

* Resolve Issue #63 (Extract Domain coverage)

* Fix error caused by repeated test names.
@ruebot ruebot moved this from To Do to In Progress in Test coverage Oct 7, 2017
@greebie greebie mentioned this issue Oct 18, 2017
Merged
@greebie greebie mentioned this issue Dec 8, 2017
Merged
@ruebot
Copy link
Member Author

@ruebot ruebot commented Dec 8, 2017

Partially addressed with: aaad971
@greebie
Copy link
Contributor

@greebie greebie commented Jan 11, 2018

Tried a number of times to improve this coverage with no success. Not sure how to test for the LowPriorityFlatten class.
@ruebot ruebot added the RA-Task label Feb 5, 2018
@ruebot ruebot moved this from In Progress to To Do in Test coverage May 21, 2018
@ruebot ruebot moved this from To Do to In Progress in Test coverage Aug 13, 2018
@ruebot ruebot moved this from In Progress to To Do in Test coverage Nov 14, 2019
@ruebot ruebot mentioned this issue May 27, 2020
Merged
ruebot added a commit that referenced this issue May 27, 2020
@ruebot
Remove tabDelimit.
Verified
This commit was signed with a verified signature.
ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
Loading status checks…
d1b0620 
- Resolves #471
- Resolves #59
- Remove TupleFormatter (tabDelimit functionality)
- Remove shapeless from pom
ianmilligan1 pushed a commit that referenced this issue May 27, 2020
@ruebot
Remove tabDelimit. (#472)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9815ea4 
- Resolves #471
- Resolves #59
- Remove TupleFormatter (tabDelimit functionality)
- Remove shapeless from pom
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greebie greebie

Labels
RA-Task tests
Projects
Test coverage
To Do
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Remove tabDelimit.
3 participants
@greebie @ruebot and others
You can’t perform that action at this time.