/aut

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve RecordLoader.scala test coverage #60

Closed
ruebot opened this Issue Oct 2, 2017 · 7 comments

Comments

Assignees

@greebie greebie

Labels
Projects
Done in Test coverage
Milestone
No milestone
2 participants
@ruebot @greebie
@ruebot
Member

ruebot commented Oct 2, 2017

RecordLoader.scala test coverage can be improved.

@ruebot ruebot added the tests label Oct 2, 2017

@ruebot ruebot added this to To Do in Test coverage Oct 2, 2017

@greebie

This comment has been minimized.

Show comment
Hide comment
@greebie

greebie Oct 4, 2017

Contributor

Going to start with this one for now.
Contributor

greebie commented Oct 4, 2017

Going to start with this one for now.

@greebie greebie self-assigned this Oct 4, 2017

@greebie greebie referenced this issue Oct 4, 2017

Merged

First round of unit tests #84

@greebie greebie closed this Oct 4, 2017

@greebie greebie reopened this Oct 4, 2017

@ruebot

This comment has been minimized.

Show comment
Hide comment
@ruebot

ruebot Oct 5, 2017

Member

Couple more lines to cover here that #84 did not cover:
https://codecov.io/gh/archivesunleashed/aut/src/master/src/main/scala/io/archivesunleashed/spark/matchbox/RecordLoader.scala
Member

ruebot commented Oct 5, 2017

Couple more lines to cover here that #84 did not cover:
https://codecov.io/gh/archivesunleashed/aut/src/master/src/main/scala/io/archivesunleashed/spark/matchbox/RecordLoader.scala

@greebie greebie referenced this issue Oct 6, 2017

Merged

Improve Test Coverage for #55, #56, #57, #58, #59, #60, #61, #62, #63, #64 & #66 #87

ruebot added a commit that referenced this issue Oct 6, 2017

@greebie @ruebot
Improve Test Coverage for #55, #56, #57, #58, #59, #60, #61, #62, #63, … 
…#64 & #66 (#87)

* Add tests for remove Tuples, CreateGDF and RemoveHTML

* Add RemoveHttpHeader test.

* Add license header to tests.

* Issues #56, #57, #58, #59, #61, #62

* resolves Issue #85 (JsonUtil)

* Fix issue # 64 (ExtractDate coverage)

* Resolve Issue #63 (Extract Domain coverage)

* Fix error caused by repeated test names.
Loading status checks…
c8b7d2e

@ruebot ruebot moved this from To Do to In Progress in Test coverage Oct 7, 2017

greebie added a commit that referenced this issue Oct 18, 2017

@greebie
Some slight test improvements for issues #60 & # 59.
Loading status checks…
f6c5210

@greebie greebie referenced this issue Oct 18, 2017

Merged

Improve coverage for issue-67 (RecordRDD.scala) #99

ruebot added a commit that referenced this issue Oct 19, 2017

@greebie @ruebot
Improve coverage for issue-67 (RecordRDD.scala) (#99) 
* Improve coverage for issue-67 (RecordRDD.scala)

* Improve coverage for issue-67 (RecordRDD.scala)

* Fix partial covers for Issue #67

* Add badexample (with broken records)
Slight improvements to RecordRDD

* This may help improve coverage slightly. Altered badexample.

* Some slight test improvements for issues #60 & # 59.
Loading status checks…
a539a1c
@ruebot

This comment has been minimized.

Show comment
Hide comment
@ruebot

ruebot Oct 19, 2017

Member

Partially addressed with: a539a1c
Member

ruebot commented Oct 19, 2017

Partially addressed with: a539a1c

@greebie greebie changed the title from Improve RemoveHTML.scala test coverage to Improve RemoveLoader.scala test coverage Dec 8, 2017

@greebie greebie changed the title from Improve RemoveLoader.scala test coverage to Improve RecordLoader.scala test coverage Dec 8, 2017

@greebie

This comment has been minimized.

Show comment
Hide comment
@greebie

greebie Dec 8, 2017

Contributor

(RemoveHTML is covered 100%)
Contributor

greebie commented Dec 8, 2017

(RemoveHTML is covered 100%)

@ruebot ruebot closed this Dec 8, 2017

@greebie greebie reopened this Dec 8, 2017

@greebie

This comment has been minimized.

Show comment
Hide comment
@greebie

greebie Dec 8, 2017

Contributor

My bad here. The RecordLoader test coverage is not 100%, it's just misnamed. I will try to work on it today.
Contributor

greebie commented Dec 8, 2017

My bad here. The RecordLoader test coverage is not 100%, it's just misnamed. I will try to work on it today.

@greebie greebie referenced this issue Dec 11, 2017

Merged

- Add tests for RecordLoader #149

@ruebot

This comment has been minimized.

Show comment
Hide comment
@ruebot

ruebot Dec 11, 2017

Member

Partially addressed with: ffb23d8
Member

ruebot commented Dec 11, 2017

Partially addressed with: ffb23d8

@ruebot ruebot added the URA-Task label Feb 5, 2018

@ruebot ruebot moved this from In Progress to To Do in Test coverage May 21, 2018

@ruebot

This comment has been minimized.

Show comment
Hide comment
@ruebot

ruebot Aug 10, 2018

Member

RecordLoader.scala is gone, and integrated elsewhere. Closing this one, and will open up a new ticket.
Member

ruebot commented Aug 10, 2018

RecordLoader.scala is gone, and integrated elsewhere. Closing this one, and will open up a new ticket.

@ruebot ruebot closed this Aug 10, 2018

@ruebot ruebot moved this from To Do to In Progress in Test coverage Aug 13, 2018

@ruebot ruebot moved this from In Progress to Done in Test coverage Aug 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment