/aut

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve RecordRDD.scala test coverage #67

Closed
ruebot opened this Issue Oct 2, 2017 · 4 comments

Comments

Assignees
No one assigned
Labels
Projects
Done in Test coverage
Milestone
No milestone
2 participants
@ruebot @greebie
@ruebot
Member

ruebot commented Oct 2, 2017

RecordRDD.scala test coverage can be improved.

@ruebot ruebot added the tests label Oct 2, 2017

@ruebot ruebot added this to To Do in Test coverage Oct 2, 2017

@ruebot

This comment has been minimized.

Show comment
Hide comment
@ruebot

ruebot Oct 13, 2017

Member

Partially addressed with: 065fb6f
Member

ruebot commented Oct 13, 2017

Partially addressed with: 065fb6f

@greebie greebie referenced this issue Oct 18, 2017

Merged

Improve coverage for issue-67 (RecordRDD.scala) #99

greebie added a commit that referenced this issue Oct 18, 2017

@greebie
Fix partial covers for Issue #67
cb197a5

ruebot added a commit that referenced this issue Oct 19, 2017

@greebie @ruebot
Improve coverage for issue-67 (RecordRDD.scala) (#99) 
* Improve coverage for issue-67 (RecordRDD.scala)

* Improve coverage for issue-67 (RecordRDD.scala)

* Fix partial covers for Issue #67

* Add badexample (with broken records)
Slight improvements to RecordRDD

* This may help improve coverage slightly. Altered badexample.

* Some slight test improvements for issues #60 & # 59.
Loading status checks…
a539a1c
@ruebot

This comment has been minimized.

Show comment
Hide comment
@ruebot

ruebot Oct 19, 2017

Member

Partially addressed with: a539a1c
Member

ruebot commented Oct 19, 2017

Partially addressed with: a539a1c
@greebie

This comment has been minimized.

Show comment
Hide comment
@greebie

greebie Oct 19, 2017

Contributor

I've tried two methods so far of creating "false" ArchiveRecord RDDs and both failed.

  • call a broken ARC file -- does not work because it will not load a broken file.
  • create a mock ArchiveRecord -- does not work because Mocks will not work deeply, and ArchiveRecord extends Serializable.

Two methods I have not tried, but may in future:

  • Create an Object that extends the ArchiveRecord trait.
  • Create a function to create an archive record from a list or string and use this to test.
Contributor

greebie commented Oct 19, 2017

I've tried two methods so far of creating "false" ArchiveRecord RDDs and both failed.

  • call a broken ARC file -- does not work because it will not load a broken file.
  • create a mock ArchiveRecord -- does not work because Mocks will not work deeply, and ArchiveRecord extends Serializable.

Two methods I have not tried, but may in future:

  • Create an Object that extends the ArchiveRecord trait.
  • Create a function to create an archive record from a list or string and use this to test.

@ruebot ruebot added the URA-Task label Feb 5, 2018

@ruebot ruebot added the wontfix label Aug 10, 2018

@ruebot

This comment has been minimized.

Show comment
Hide comment
@ruebot

ruebot Aug 10, 2018

Member

RecordRDD.scala is gone.
Member

ruebot commented Aug 10, 2018

RecordRDD.scala is gone.

@ruebot ruebot closed this Aug 10, 2018

@ruebot ruebot moved this from To Do to Done in Test coverage Aug 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment