Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd/jobs clean nightly #183
Conversation
this will be run as a nightly task, and will push to master after checking over the list of jobs and only checking those that are expired, and of that set, it it does not return a successful response we remove it from the list. I am opening this with a trigger on PR so that I can test, and also am not allowing the push to master to happen. When the script seems to run okay I will remove the pull request trigger and then the exit code before push, and we will test fully for the first overnight run. Signed-off-by: vsoch <vsochat@stanford.edu>
This comment has been minimized.
This comment has been minimized.
|
okay, I've just removed the exit before push and trigger on PR, and here is the previous run for others to see https://github.com/USRSE/usrse.github.io/pull/183/checks?check_run_id=537201915 please see the section "install dependencies and run script" of "clean-jobs." When this runs overnight it won't run the urlchecker.yml alongside it, but it does use the action after the new script is generated. Also note that it uses the same exact function to check/retry checking urls as the action, so we are consistent. I'm also renaming that step so it's more clear to look there to rename jobs. See line https://github.com/USRSE/usrse.github.io/pull/183/files#diff-b5500c14d3568dce69acae665b4051c8R16. |
| def read_jobs(filepath): | ||
| """read in the jobs data. | ||
| """ | ||
| # Read in the entire membership counts |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
vsoch
Mar 27, 2020
Author
Member
You got me! I was adopting the previous function from update membership counts. Fixing right away!
This comment has been minimized.
This comment has been minimized.
|
I think this looks good, with the exception of some documentation issues, one typo and two things that look like they were copied from another program and not changes for this purpose. |
This comment has been minimized.
This comment has been minimized.
|
Yes that's absolutely correct - I started with a similar file and changed most of it (but missed a few of the docstrings!) pushing a fix right away. |
This comment has been minimized.
This comment has been minimized.
|
All set @danielskatz. |
This comment has been minimized.
This comment has been minimized.
|
looks like @cosden renamed https://us-rse.org/2020-april-workshop to https://us-rse.org/2020-oct-workshop (and this is expected to change again!) I'll fix it here for now so the link isn't dead, and then the next fix will need to be in #184. |
This comment has been minimized.
This comment has been minimized.
|
looks good - go ahead and merge, then we'll see how it works in practice going forward |
This comment has been minimized.
This comment has been minimized.
|
Great! Yes, I will be watching this, and promptly respond if anything needs attention. |
vsoch commentedMar 26, 2020
Description
This PR is a WIP to add a nightly run to test for expired jobs, and remove them. This will be run as a nightly task, and will push to master after checking over the list of jobs and only checking those that are expired, and of that set, it it does not return a successful response we remove it from the list. I am opening this with a trigger on PR so that I can test, and also am not allowing the push to master to happen. When the script seems to run okay I will remove the pull request trigger and then the exit code before push, and we will test fully for the first overnight run.
I will likely need to run this a few times to test and change, so do not consider it ready for review.
Signed-off-by: vsoch vsochat@stanford.edu
cc @usrse-maintainers