Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd option to save to Parquet for app. #454
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
|
I'll get a documentation PR ready to go once archivesunleashed/aut-docs#58 is merged. |
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Apr 22, 2020
•
Codecov Report
@@ Coverage Diff @@
## master #454 +/- ##
==========================================
- Coverage 76.70% 76.59% -0.12%
==========================================
Files 49 49
Lines 1421 1457 +36
Branches 264 279 +15
==========================================
+ Hits 1090 1116 +26
+ Misses 215 211 -4
- Partials 116 130 +14 |
This comment has been minimized.
This comment has been minimized.
|
Forgot to mention that I tested loading up both version of Parquet output into a Juypter notebook, and everything went smoothly. |
ruebot
added a commit
to archivesunleashed/aut-docs
that referenced
this pull request
Apr 22, 2020
ruebot
added a commit
to archivesunleashed/aut-docs
that referenced
this pull request
Apr 22, 2020
#59) * Documentation update for archivesunleashed/aut#454
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ruebot commentedApr 22, 2020
#453 needs to be merged first
GitHub issue(s): #448
What does this Pull Request do?
Add option to save to Parquet for app.
How should this be tested?
Something like:
bin/spark-submit --class io.archivesunleashed.app.CommandLineAppRunner /home/nruest/Projects/au/aut/target/aut-0.60.1-SNAPSHOT-fatjar.jar --extractor AudioInformationExtractor --input /home/nruest/Projects/au/sample-data/geocities/* --output /home/nruest/Projects/au/sample-data/452-test/audioParquet --output-format parquetbin/spark-submit --class io.archivesunleashed.app.CommandLineAppRunner /home/nruest/Projects/au/aut/target/aut-0.60.1-SNAPSHOT-fatjar.jar --extractor AudioInformationExtractor --input /home/nruest/Projects/au/sample-data/geocities/* --output /home/nruest/Projects/au/sample-data/452-test/audioParquetSingle --output-format parquet --partition 1bin/spark-submit --class io.archivesunleashed.app.CommandLineAppRunner /home/nruest/Projects/au/aut/target/aut-0.60.1-SNAPSHOT-fatjar.jar --extractor AudioInformationExtractor --input /home/nruest/Projects/au/sample-data/geocities/* --output /home/nruest/Projects/au/sample-data/452-test/audioCsv --partition 1Additional Notes:
We should probably loop back around and clean all this up at some point. It's a little messy.