Skip to content

/aut

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala Checkstyle warnings #196

Closed
ruebot opened this issue Apr 11, 2018 · 5 comments

Comments

@ruebot
Copy link
Member

commented Apr 11, 2018

Now that we've resolved #176 and #184, and implemented the equivalent of Checkstyle for Scala, do we want to resolve these Scala Checkstyle warnings?

[INFO] --- scalastyle-maven-plugin:1.0.0:check (default) @ aut ---
warning file=src/main/scala/io/archivesunleashed/package.scala message=Avoid using null line=60 column=70
warning file=src/main/scala/io/archivesunleashed/package.scala message=Public method must have explicit type line=90 column=8
warning file=src/main/scala/io/archivesunleashed/package.scala message=Public method must have explicit type line=105 column=8
warning file=src/main/scala/io/archivesunleashed/package.scala message=Public method must have explicit type line=114 column=8
warning file=src/main/scala/io/archivesunleashed/package.scala message=Public method must have explicit type line=122 column=8
warning file=src/main/scala/io/archivesunleashed/package.scala message=Public method must have explicit type line=130 column=8
warning file=src/main/scala/io/archivesunleashed/package.scala message=Public method must have explicit type line=143 column=8
warning file=src/main/scala/io/archivesunleashed/package.scala message=Public method must have explicit type line=151 column=8
warning file=src/main/scala/io/archivesunleashed/package.scala message=Public method must have explicit type line=159 column=8
warning file=src/main/scala/io/archivesunleashed/package.scala message=Public method must have explicit type line=172 column=8
warning file=src/main/scala/io/archivesunleashed/package.scala message=Public method must have explicit type line=176 column=8
warning file=src/main/scala/io/archivesunleashed/package.scala message=Public method must have explicit type line=180 column=8
warning file=src/main/scala/io/archivesunleashed/package.scala message=Public method must have explicit type line=184 column=8
warning file=src/main/scala/io/archivesunleashed/package.scala message=Public method must have explicit type line=193 column=8
warning file=src/main/scala/io/archivesunleashed/package.scala message=Public method must have explicit type line=197 column=8
warning file=src/main/scala/io/archivesunleashed/package.scala message=Avoid wildcard imports line=24 column=0
warning file=src/main/scala/io/archivesunleashed/package.scala message=Avoid wildcard imports line=28 column=0
warning file=src/main/scala/io/archivesunleashed/package.scala message=Avoid wildcard imports line=29 column=0
warning file=src/main/scala/io/archivesunleashed/package.scala message=Insert a space after the start of the comment line=38 column=2
warning file=src/main/scala/io/archivesunleashed/matchbox/DetectMimeTypeTika.scala message=If block needs braces line=33 column=4
warning file=src/main/scala/io/archivesunleashed/matchbox/package.scala message=Avoid using return line=29 column=21
warning file=src/main/scala/io/archivesunleashed/matchbox/package.scala message=Avoid using return line=35 column=8
warning file=src/main/scala/io/archivesunleashed/matchbox/package.scala message=Avoid using return line=44 column=6
warning file=src/main/scala/io/archivesunleashed/matchbox/package.scala message=Avoid using null line=29 column=28
warning file=src/main/scala/io/archivesunleashed/matchbox/package.scala message=Avoid wildcard imports line=23 column=0
warning file=src/main/scala/io/archivesunleashed/matchbox/ExtractDomain.scala message=Avoid using return line=30 column=21
warning file=src/main/scala/io/archivesunleashed/matchbox/ExtractDomain.scala message=Avoid using return line=37 column=40
warning file=src/main/scala/io/archivesunleashed/matchbox/ExtractDomain.scala message=Avoid using null line=30 column=28
warning file=src/main/scala/io/archivesunleashed/matchbox/ExtractDomain.scala message=Avoid using null line=31 column=23
warning file=src/main/scala/io/archivesunleashed/matchbox/ExtractDomain.scala message=Avoid using null line=41 column=27
warning file=src/main/scala/io/archivesunleashed/matchbox/RemoveHttpHeader.scala message=Avoid using null line=37 column=8
warning file=src/main/scala/io/archivesunleashed/matchbox/RemoveHttpHeader.scala message=Regular expression matched 'println' line=36 column=8
warning file=src/main/scala/io/archivesunleashed/matchbox/RemoveHttpHeader.scala message=If block needs braces line=30 column=6
warning file=src/main/scala/io/archivesunleashed/matchbox/ExtractImageLinks.scala message=Avoid using return line=34 column=22
warning file=src/main/scala/io/archivesunleashed/matchbox/TupleFormatter.scala message=Object name does not match the regular expression '^[A-Z][A-Za-z]*$' line=32 column=9
warning file=src/main/scala/io/archivesunleashed/matchbox/TupleFormatter.scala message=Object name does not match the regular expression '^[A-Z][A-Za-z]*$' line=38 column=9
warning file=src/main/scala/io/archivesunleashed/matchbox/TupleFormatter.scala message=Public method must have explicit type line=28 column=17
warning file=src/main/scala/io/archivesunleashed/matchbox/TupleFormatter.scala message=Public method must have explicit type line=33 column=17
warning file=src/main/scala/io/archivesunleashed/matchbox/TupleFormatter.scala message=Public method must have explicit type line=39 column=17
warning file=src/main/scala/io/archivesunleashed/matchbox/TupleFormatter.scala message=Avoid wildcard imports line=19 column=0
warning file=src/main/scala/io/archivesunleashed/matchbox/TupleFormatter.scala message=Avoid wildcard imports line=22 column=0
warning file=src/main/scala/io/archivesunleashed/matchbox/ComputeMD5.scala message=Object name does not match the regular expression '^[A-Z][A-Za-z]*$' line=22 column=7
warning file=src/main/scala/io/archivesunleashed/matchbox/ComputeImageSize.scala message=Avoid using return line=38 column=8
warning file=src/main/scala/io/archivesunleashed/matchbox/ComputeImageSize.scala message=Avoid using return line=42 column=8
warning file=src/main/scala/io/archivesunleashed/matchbox/ComputeImageSize.scala message=If block needs braces line=37 column=6
warning file=src/main/scala/io/archivesunleashed/matchbox/ExtractLinks.scala message=Avoid using return line=39 column=23
warning file=src/main/scala/io/archivesunleashed/matchbox/ExtractLinks.scala message=Avoid using return line=40 column=24
warning file=src/main/scala/io/archivesunleashed/matchbox/ExtractBoilerpipeText.scala message=If block needs braces line=33 column=6
warning file=src/main/scala/io/archivesunleashed/matchbox/ExtractBoilerpipeText.scala message=If block needs braces line=48 column=4
warning file=src/main/scala/io/archivesunleashed/matchbox/ExtractBoilerpipeText.scala message=Public method must have explicit type line=31 column=6
warning file=src/main/scala/io/archivesunleashed/matchbox/ExtractBoilerpipeText.scala message=Public method must have explicit type line=46 column=6
warning file=src/main/scala/io/archivesunleashed/matchbox/RemoveHTML.scala message=Public method must have explicit type line=30 column=6
warning file=src/main/scala/io/archivesunleashed/matchbox/DetectLanguage.scala message=If block needs braces line=30 column=4
warning file=src/main/scala/io/archivesunleashed/matchbox/NER3Classifier.scala message=Object name does not match the regular expression '^[A-Z][A-Za-z]*$' line=29 column=7
warning file=src/main/scala/io/archivesunleashed/matchbox/NER3Classifier.scala message=Avoid using return line=67 column=23
warning file=src/main/scala/io/archivesunleashed/matchbox/NER3Classifier.scala message=Cyclomatic complexity of 16 exceeds max of 10 line=59 column=6
warning file=src/main/scala/io/archivesunleashed/matchbox/NER3Classifier.scala message=If block needs braces line=89 column=12
warning file=src/main/scala/io/archivesunleashed/matchbox/NER3Classifier.scala message=Method is longer than 50 lines line=59 column=6
warning file=src/main/scala/io/archivesunleashed/matchbox/NER3Classifier.scala message=Public method must have explicit type line=50 column=6
warning file=src/main/scala/io/archivesunleashed/matchbox/NER3Classifier.scala message=Use braces in for comprehensions line=62 column=8
warning file=src/main/scala/io/archivesunleashed/matchbox/ExtractDate.scala message=Magic Number line=35 column=41
warning file=src/main/scala/io/archivesunleashed/matchbox/ExtractDate.scala message=Magic Number line=36 column=36
warning file=src/main/scala/io/archivesunleashed/matchbox/ExtractDate.scala message=Magic Number line=36 column=39
warning file=src/main/scala/io/archivesunleashed/matchbox/ExtractDate.scala message=Magic Number line=37 column=36
warning file=src/main/scala/io/archivesunleashed/matchbox/ExtractDate.scala message=Magic Number line=37 column=39
warning file=src/main/scala/io/archivesunleashed/matchbox/ExtractDate.scala message=Magic Number line=38 column=43
warning file=src/main/scala/io/archivesunleashed/matchbox/ExtractDate.scala message=Magic Number line=39 column=38
warning file=src/main/scala/io/archivesunleashed/matchbox/ExtractDate.scala message=If block needs braces line=33 column=4
warning file=src/main/scala/io/archivesunleashed/matchbox/ExtractDate.scala message=Avoid wildcard imports line=26 column=2
warning file=src/main/scala/io/archivesunleashed/ArchiveRecordImpl.scala message=Avoid using null line=38 column=29
warning file=src/main/scala/io/archivesunleashed/ArchiveRecordImpl.scala message=Avoid using null line=39 column=31
warning file=src/main/scala/io/archivesunleashed/ArchiveRecordImpl.scala message=If block needs braces line=41 column=2
warning file=src/main/scala/io/archivesunleashed/ArchiveRecordImpl.scala message=If block needs braces line=43 column=7
warning file=src/main/scala/io/archivesunleashed/ArchiveRecordImpl.scala message=If block needs braces line=97 column=4
warning file=src/main/scala/io/archivesunleashed/app/ExtractPopularImages.scala message=Magic Number line=35 column=86
warning file=src/main/scala/io/archivesunleashed/app/ExtractPopularImages.scala message=Magic Number line=35 column=107
warning file=src/main/scala/io/archivesunleashed/app/ExtractPopularImages.scala message=Regular expression matched 'println' line=44 column=21
warning file=src/main/scala/io/archivesunleashed/app/ExtractPopularImages.scala message=Public method must have explicit type line=35 column=6
warning file=src/main/scala/io/archivesunleashed/app/ExtractPopularImages.scala message=Avoid wildcard imports line=19 column=0
warning file=src/main/scala/io/archivesunleashed/app/WriteGraphML.scala message=Avoid using return line=74 column=4
warning file=src/main/scala/io/archivesunleashed/app/WriteGraphML.scala message=If block needs braces line=37 column=4
warning file=src/main/scala/io/archivesunleashed/app/WriteGraphML.scala message=Avoid wildcard imports line=19 column=0
warning file=src/main/scala/io/archivesunleashed/app/WriteGEXF.scala message=Avoid using return line=79 column=4
warning file=src/main/scala/io/archivesunleashed/app/WriteGEXF.scala message=If block needs braces line=38 column=4
warning file=src/main/scala/io/archivesunleashed/app/WriteGEXF.scala message=Avoid wildcard imports line=19 column=0
warning file=src/main/scala/io/archivesunleashed/app/WriteGEXF.scala message=The string literal "\" />\n" appears 3 times in the file. line=54 column=49
warning file=src/main/scala/io/archivesunleashed/app/ExtractEntities.scala message=Avoid wildcard imports line=19 column=0
warning file=src/main/scala/io/archivesunleashed/app/ExtractGraph.scala message=Magic Number line=51 column=54
warning file=src/main/scala/io/archivesunleashed/app/ExtractGraph.scala message=Public method must have explicit type line=97 column=8
warning file=src/main/scala/io/archivesunleashed/app/ExtractGraph.scala message=Avoid wildcard imports line=19 column=0
warning file=src/main/scala/io/archivesunleashed/app/ExtractGraph.scala message=Avoid wildcard imports line=20 column=0
warning file=src/main/scala/io/archivesunleashed/app/ExtractGraph.scala message=Avoid wildcard imports line=22 column=0
warning file=src/main/scala/io/archivesunleashed/app/NERCombinedJson.scala message=Magic Number line=57 column=40
warning file=src/main/scala/io/archivesunleashed/app/NERCombinedJson.scala message=Avoid using null line=61 column=74
warning file=src/main/scala/io/archivesunleashed/app/NERCombinedJson.scala message=Avoid wildcard imports line=24 column=0
warning file=src/main/scala/io/archivesunleashed/app/NERCombinedJson.scala message=Use : Unit = for procedures line=89 column=6
warning file=src/main/scala/io/archivesunleashed/util/TweetUtils.scala message=Avoid using null line=31 column=95
warning file=src/main/scala/io/archivesunleashed/util/TweetUtils.scala message=Avoid using null line=33 column=106
warning file=src/main/scala/io/archivesunleashed/util/TweetUtils.scala message=Avoid using null line=35 column=95
warning file=src/main/scala/io/archivesunleashed/util/TweetUtils.scala message=Avoid using null line=37 column=93
warning file=src/main/scala/io/archivesunleashed/util/TweetUtils.scala message=Avoid using null line=39 column=115
warning file=src/main/scala/io/archivesunleashed/util/TweetUtils.scala message=Avoid wildcard imports line=19 column=0
warning file=src/main/scala/io/archivesunleashed/util/TweetUtils.scala message=The string literal "user" appears 4 times in the file. line=39 column=44
warning file=src/test/scala/io/archivesunleashed/ArcTest.scala message=Magic Number line=56 column=50
warning file=src/test/scala/io/archivesunleashed/ArcTest.scala message=Magic Number line=57 column=50
warning file=src/test/scala/io/archivesunleashed/ArcTest.scala message=Regular expression matched 'println' line=102 column=8
warning file=src/test/scala/io/archivesunleashed/ArcTest.scala message=Avoid wildcard imports line=25 column=0
warning file=src/test/scala/io/archivesunleashed/ArcTest.scala message=The string literal "200805" appears 3 times in the file. line=47 column=30
warning file=src/test/scala/io/archivesunleashed/RecordRDDTest.scala message=Avoid wildcard imports line=19 column=0
warning file=src/test/scala/io/archivesunleashed/RecordRDDTest.scala message=The string literal "http://www.archive.org/" appears 4 times in the file. line=71 column=33
warning file=src/test/scala/io/archivesunleashed/RecordRDDTest.scala message=The string literal "http://www.sloan.org" appears 4 times in the file. line=71 column=60
warning file=src/test/scala/io/archivesunleashed/RecordRDDTest.scala message=The string literal "Please visit our website at" appears 4 times in the file. line=106 column=23
warning file=src/test/scala/io/archivesunleashed/WarcTest.scala message=Magic Number line=52 column=12
warning file=src/test/scala/io/archivesunleashed/matchbox/RemoveHttpHeaderTest.scala message=Avoid using null line=31 column=33
warning file=src/test/scala/io/archivesunleashed/matchbox/TupleFormatterTest.scala message=There should be no space before a left bracket '[' line=39 column=44
warning file=src/test/scala/io/archivesunleashed/matchbox/TupleFormatterTest.scala message=There should be no space before a left bracket '[' line=43 column=36
warning file=src/test/scala/io/archivesunleashed/matchbox/TupleFormatterTest.scala message=There should be no space before a left bracket '[' line=44 column=39
warning file=src/test/scala/io/archivesunleashed/matchbox/TupleFormatterTest.scala message=Avoid wildcard imports line=22 column=0
warning file=src/test/scala/io/archivesunleashed/matchbox/TupleFormatterTest.scala message=Avoid wildcard imports line=25 column=0
warning file=src/test/scala/io/archivesunleashed/matchbox/TupleFormatterTest.scala message=Avoid wildcard imports line=26 column=0
warning file=src/test/scala/io/archivesunleashed/matchbox/TupleFormatterTest.scala message=The string literal "a" appears 3 times in the file. line=31 column=18
warning file=src/test/scala/io/archivesunleashed/matchbox/TupleFormatterTest.scala message=The string literal "c" appears 3 times in the file. line=31 column=29
warning file=src/test/scala/io/archivesunleashed/matchbox/ExtractTextFromPDFsTest.scala message=There should be no space before a left bracket '[' line=30 column=44
warning file=src/test/scala/io/archivesunleashed/matchbox/ExtractTextFromPDFsTest.scala message=Avoid wildcard imports line=23 column=1
warning file=src/test/scala/io/archivesunleashed/matchbox/ExtractTextFromPDFsTest.scala message=Avoid wildcard imports line=24 column=1
warning file=src/test/scala/io/archivesunleashed/matchbox/ExtractLinksTest.scala message=Avoid using null line=50 column=24
warning file=src/test/scala/io/archivesunleashed/matchbox/ExtractLinksTest.scala message=Avoid using null line=53 column=46
warning file=src/test/scala/io/archivesunleashed/matchbox/ExtractLinksTest.scala message=The string literal "Here is <a href=\"http://www.google.com\">a search engine</a>.\n" appears 3 times in the file. line=28 column=27
warning file=src/test/scala/io/archivesunleashed/matchbox/ExtractLinksTest.scala message=The string literal "http://www.foobar.org/index.html" appears 3 times in the file. line=39 column=78
warning file=src/test/scala/io/archivesunleashed/matchbox/ComputeImageSizeTest.scala message=Import from illegal package line=23 column=0
warning file=src/test/scala/io/archivesunleashed/matchbox/ComputeImageSizeTest.scala message=Magic Number line=29 column=30
warning file=src/test/scala/io/archivesunleashed/matchbox/ComputeImageSizeTest.scala message=Magic Number line=29 column=34
warning file=src/test/scala/io/archivesunleashed/matchbox/ComputeImageSizeTest.scala message=Avoid using null line=38 column=28
warning file=src/test/scala/io/archivesunleashed/matchbox/RemoveHTMLTest.scala message=Avoid using null line=39 column=53
warning file=src/test/scala/io/archivesunleashed/matchbox/ExtractDomainTest.scala message=Avoid using null line=30 column=19
warning file=src/test/scala/io/archivesunleashed/matchbox/ExtractDomainTest.scala message=Avoid using null line=34 column=31
warning file=src/test/scala/io/archivesunleashed/matchbox/ExtractDomainTest.scala message=Avoid using null line=48 column=25
warning file=src/test/scala/io/archivesunleashed/matchbox/ExtractDomainTest.scala message=Avoid using null line=49 column=39
warning file=src/test/scala/io/archivesunleashed/matchbox/ExtractDomainTest.scala message=The string literal "index.html" appears 4 times in the file. line=30 column=5
warning file=src/test/scala/io/archivesunleashed/matchbox/ExtractImageLinksTest.scala message=Avoid using null line=50 column=18
warning file=src/test/scala/io/archivesunleashed/matchbox/StringUtilsTest.scala message=Avoid using null line=29 column=20
warning file=src/test/scala/io/archivesunleashed/matchbox/StringUtilsTest.scala message=Avoid using null line=36 column=25
warning file=src/test/scala/io/archivesunleashed/matchbox/ExtractDateTest.scala message=Magic Number line=37 column=67
warning file=src/test/scala/io/archivesunleashed/matchbox/ExtractDateTest.scala message=Magic Number line=38 column=63
warning file=src/test/scala/io/archivesunleashed/matchbox/ExtractDateTest.scala message=Magic Number line=38 column=65
warning file=src/test/scala/io/archivesunleashed/matchbox/ExtractDateTest.scala message=Magic Number line=39 column=63
warning file=src/test/scala/io/archivesunleashed/matchbox/ExtractDateTest.scala message=Magic Number line=39 column=65
warning file=src/test/scala/io/archivesunleashed/matchbox/ExtractDateTest.scala message=Magic Number line=40 column=69
warning file=src/test/scala/io/archivesunleashed/matchbox/ExtractDateTest.scala message=Magic Number line=41 column=71
warning file=src/test/scala/io/archivesunleashed/matchbox/ExtractDateTest.scala message=Avoid using null line=33 column=23
warning file=src/test/scala/io/archivesunleashed/matchbox/ExtractDateTest.scala message=Avoid wildcard imports line=22 column=0
warning file=src/test/scala/io/archivesunleashed/matchbox/ExtractDateTest.scala message=The string literal "20151204" appears 16 times in the file. line=28 column=23
warning file=src/test/scala/io/archivesunleashed/matchbox/ExtractBoilerPipeTextTest.scala message=Avoid using null line=34 column=65
warning file=src/test/scala/io/archivesunleashed/app/WriteGEXFTest.scala message=Magic Number line=53 column=17
warning file=src/test/scala/io/archivesunleashed/app/WriteGEXFTest.scala message=Magic Number line=54 column=17
warning file=src/test/scala/io/archivesunleashed/app/WriteGEXFTest.scala message=Magic Number line=55 column=17
warning file=src/test/scala/io/archivesunleashed/app/WriteGEXFTest.scala message=Regular expression matched 'println' line=51 column=4
warning file=src/test/scala/io/archivesunleashed/app/WriteGEXFTest.scala message=Regular expression matched 'println' line=61 column=4
warning file=src/test/scala/io/archivesunleashed/app/WriteGEXFTest.scala message=Boolean expression can be simplified line=49 column=11
warning file=src/test/scala/io/archivesunleashed/app/WriteGEXFTest.scala message=Boolean expression can be simplified line=62 column=11
warning file=src/test/scala/io/archivesunleashed/app/WriteGEXFTest.scala message=Boolean expression can be simplified line=63 column=11
warning file=src/test/scala/io/archivesunleashed/app/WriteGraphMLTest.scala message=Magic Number line=52 column=17
warning file=src/test/scala/io/archivesunleashed/app/WriteGraphMLTest.scala message=Magic Number line=53 column=17
warning file=src/test/scala/io/archivesunleashed/app/WriteGraphMLTest.scala message=Magic Number line=54 column=17
warning file=src/test/scala/io/archivesunleashed/app/WriteGraphMLTest.scala message=Regular expression matched 'println' line=60 column=4
warning file=src/test/scala/io/archivesunleashed/app/WriteGraphMLTest.scala message=Boolean expression can be simplified line=49 column=11
warning file=src/test/scala/io/archivesunleashed/app/WriteGraphMLTest.scala message=Boolean expression can be simplified line=61 column=11
warning file=src/test/scala/io/archivesunleashed/app/WriteGraphMLTest.scala message=Boolean expression can be simplified line=62 column=11
warning file=src/test/scala/io/archivesunleashed/app/ExtractEntitiesTest.scala message=Insert a space after the start of the comment line=33 column=0
warning file=src/test/scala/io/archivesunleashed/app/ExtractPopularImagesTest.scala message=Line contains a tab line=47 column=29
warning file=src/test/scala/io/archivesunleashed/app/ExtractPopularImagesTest.scala message=Line contains a tab line=48 column=10
warning file=src/test/scala/io/archivesunleashed/app/ExtractPopularImagesTest.scala message=Line contains a tab line=49 column=10
warning file=src/test/scala/io/archivesunleashed/app/ExtractPopularImagesTest.scala message=Magic Number line=46 column=61
warning file=src/test/scala/io/archivesunleashed/app/ExtractGraphTest.scala message=Boolean expression can be simplified line=83 column=15
warning file=src/test/scala/io/archivesunleashed/app/ExtractGraphTest.scala message=Boolean expression can be simplified line=84 column=15
warning file=src/test/scala/io/archivesunleashed/app/ExtractGraphTest.scala message=Avoid wildcard imports line=24 column=0
warning file=src/test/scala/io/archivesunleashed/app/ExtractGraphTest.scala message=The string literal "epic.org" appears 4 times in the file. line=52 column=59
warning file=src/test/scala/io/archivesunleashed/app/ExtractGraphTest.scala message=The string literal "20080430" appears 8 times in the file. line=55 column=55
warning file=src/test/scala/io/archivesunleashed/app/ExtractGraphTest.scala message=The string literal "deadlists.com" appears 12 times in the file. line=55 column=66
warning file=src/test/scala/io/archivesunleashed/util/JsonUtilsTest.scala message=Magic Number line=34 column=29
warning file=src/test/scala/io/archivesunleashed/util/TweetUtilsTest.scala message=Boolean expression can be simplified line=44 column=11
warning file=src/test/scala/io/archivesunleashed/util/TweetUtilsTest.scala message=Boolean expression can be simplified line=65 column=13
warning file=src/test/scala/io/archivesunleashed/util/TweetUtilsTest.scala message=Avoid wildcard imports line=19 column=0
warning file=src/test/scala/io/archivesunleashed/util/TweetUtilsTest.scala message=Avoid wildcard imports line=20 column=0
warning file=src/test/scala/io/archivesunleashed/util/TweetUtilsTest.scala message=Avoid wildcard imports line=21 column=0
warning file=src/test/scala/io/archivesunleashed/CountableRDDTest.scala message=Avoid wildcard imports line=19 column=0
warning file=src/test/scala/io/archivesunleashed/RecordLoaderTest.scala message=Avoid wildcard imports line=27 column=1

@ruebot ruebot added the question label Apr 11, 2018

@greebie

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Apr 11, 2018

Short answer is "yes" in my opinion in the long run (maybe before 1.0.0 release). We should try to pick these off, as best we can. Only caveat is this compared to other priorities.

@ruebot ruebot added this to To Do in 1.0.0 Release of AUT Apr 13, 2018

@greebie

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Apr 27, 2018

Use mvn scalastyle:check to run the checks. I created a branch to work on this now.

Some of the requested changes could change behavior, so this will need to be tested pretty heartily before being accepted.
This was referenced Apr 27, 2018
Closed
Closed
@greebie greebie referenced this issue Jul 31, 2018
Merged

ruebot added a commit that referenced this issue Aug 1, 2018

@greebie @ruebot
Address main scalastyle errors - #196 (#248) 
* Deal with wildcard import lint issues.
* Fix some magic numbers & duplicate string runs.
* Lint fixes, mostly explicit import warnings.
* All other scalastyle issues require refactoring.
Loading status checks…
77dbd51
@ruebot

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Aug 1, 2018

Partially addressed with 77dbd51

@ruebot ruebot closed this in 004ce1f Aug 9, 2018

1.0.0 Release of AUT automation moved this from To Do to Done Aug 9, 2018

ruebot added a commit that referenced this issue Aug 8, 2019

@ruebot
More scalastyle work; addresses #196. 
- Remove all underscore imports, except shapeless
- Address all scalastyle warnings
- Update scalastyle config for magic numbers, and null (only used in
tests)
Verified
This commit was signed with a verified signature.
ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
Loading status checks…
eb4f3ea
@ruebot ruebot referenced this issue Aug 8, 2019
Merged
@ruebot

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Aug 8, 2019

LOL, 364 days since the last commit on this issue.
@ianmilligan1

This comment has been minimized.

Sign in to view
Copy link
Member

commented Aug 8, 2019

Every August 8th, our project commits to addressing Scala Checkstyle warnings.

ianmilligan1 added a commit that referenced this issue Aug 8, 2019

@ruebot @ianmilligan1
More scalastyle work; addresses #196. (#339) 
- Remove all underscore imports, except shapeless
- Address all scalastyle warnings
- Update scalastyle config for magic numbers, and null (only used in
tests)
Loading status checks…
b2d7394
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
  
Done in 1.0.0 Release of AUT
Milestone
No milestone
3 participants
@ruebot @greebie @ianmilligan1
You can’t perform that action at this time.