Skip to content

/aut

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More scalastyle work; addresses #196. #339

Merged
merged 1 commit into from Aug 8, 2019
+92 −93

Conversation

@ruebot
Copy link
Member

commented Aug 8, 2019

GitHub issue(s): #196

What does this Pull Request do?

More scalastyle work; addresses #196.

  • Remove all underscore imports, except shapeless
  • Address all scalastyle warnings
  • Update scalastyle config for magic numbers, and null (only used in
    tests)

How should this be tested?

TravisCI

Additional Notes:

The shapeless imports in TupleFormatter are a little hairy. I'll loop back around to them sometime in the future.
@ruebot
More scalastyle work; addresses #196. 
- Remove all underscore imports, except shapeless
- Address all scalastyle warnings
- Update scalastyle config for magic numbers, and null (only used in
tests)
Verified
This commit was signed with a verified signature.
ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
Loading status checks…
eb4f3ea

@ruebot ruebot requested a review from ianmilligan1 Aug 8, 2019

@codecov

This comment has been minimized.

Sign in to view
Copy link

commented Aug 8, 2019

Codecov Report

Merging #339 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #339   +/-   ##
=======================================
  Coverage   74.95%   74.95%           
=======================================
  Files          39       39           
  Lines        1122     1122           
  Branches      197      197           
=======================================
  Hits          841      841           
  Misses        214      214           
  Partials       67       67
Impacted Files Coverage Δ
...c/main/scala/io/archivesunleashed/df/package.scala 95.23% <ø> (ø) ⬆️
...scala/io/archivesunleashed/app/WriteGraphXML.scala 100% <ø> (ø) ⬆️
...scala/io/archivesunleashed/app/ExtractGraphX.scala 92.1% <ø> (ø) ⬆️
...in/scala/io/archivesunleashed/app/WriteGraph.scala 98.38% <ø> (ø) ⬆️
.../scala/io/archivesunleashed/app/WriteGraphML.scala 100% <ø> (ø) ⬆️
...ala/io/archivesunleashed/app/NERCombinedJson.scala 0% <ø> (ø) ⬆️
...ala/io/archivesunleashed/app/ExtractEntities.scala 0% <ø> (ø) ⬆️
...ain/scala/io/archivesunleashed/app/WriteGEXF.scala 100% <ø> (ø) ⬆️
...la/io/archivesunleashed/matchbox/ExtractDate.scala 72.22% <ø> (ø) ⬆️
...n/scala/io/archivesunleashed/DataFrameLoader.scala 100% <ø> (ø) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9623c7a...eb4f3ea. Read the comment docs.
@ianmilligan1

ianmilligan1 approved these changes Aug 8, 2019
View changes

Copy link
Member

left a comment

Looks great (and kicked the tires locally and all checks out)!

@ianmilligan1 ianmilligan1 merged commit b2d7394 into master Aug 8, 2019
3 checks passed

3 checks passed

codecov/patch Coverage not affected when comparing 9623c7a...eb4f3ea
Details
codecov/project 74.95% remains the same compared to 9623c7a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ianmilligan1 ianmilligan1 deleted the underscores branch Aug 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianmilligan1 ianmilligan1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ruebot @ianmilligan1
You can’t perform that action at this time.