Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub action - Run isort and black on Python code #488

Closed
ruebot opened this issue Jun 26, 2020 · 0 comments
Closed

GitHub action - Run isort and black on Python code #488

ruebot opened this issue Jun 26, 2020 · 0 comments
Assignees
Labels

Comments

@ruebot
Copy link
Member

@ruebot ruebot commented Jun 26, 2020

Similar to #484 and #486, we should make sure the Python code base is formatted nicely.

@ruebot ruebot self-assigned this Jun 26, 2020
ruebot added a commit that referenced this issue Jun 26, 2020
- Setup Python formatter that runs isort and black.
- Rename scala formatter, so all three are consistent now.
- Resolves #488
- Normalize all the formatters
- Sets all the formatters to run, but not apply changes. It would be helpful to do this, but we can't because we can't do
that, because we can't push to a person's PR.
- Apply isort/black
- Make sure isort and black are consistent in how they are opinionated
about imports
ianmilligan1 pushed a commit that referenced this issue Jun 26, 2020
- Setup Python formatter that runs isort and black.
- Rename scala formatter, so all three are consistent now.
- Resolves #488
- Normalize all the formatters
- Sets all the formatters to run, but not apply changes. It would be helpful to do this, but we can't because we can't do
that, because we can't push to a person's PR.
- Apply isort/black
- Make sure isort and black are consistent in how they are opinionated
about imports
- Use scalafmt 2.3.2 (same as GH action)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

1 participant
You can’t perform that action at this time.