Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd Python formatter GitHub Action. #489
Merged
+83
−97
Conversation
- Setup Python formatter that runs isort and black. - Rename scala formatter, so all three are consistent now. - Resolves #488 - Normalize all the formatters - Sets all the formatters to run, but not apply changes. It would be helpful to do this, but we can't because we can't do that, because we can't push to a person's PR. - Apply isort/black - Make sure isort and black are consistent in how they are opinionated about imports
codecov
bot
commented
Jun 26, 2020
•
Codecov Report
@@ Coverage Diff @@
## master #489 +/- ##
============================================
+ Coverage 88.20% 88.85% +0.65%
Complexity 57 57
============================================
Files 43 43
Lines 958 1014 +56
Branches 86 86
============================================
+ Hits 845 901 +56
Misses 74 74
Partials 39 39 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ruebot commentedJun 26, 2020
GitHub issue(s): #488
What does this Pull Request do?
that, because we can't push to a person's PR.
about imports
How should this be tested?