Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ExtractImageDetailsDF.scala #464

Closed
ruebot opened this issue May 24, 2020 · 1 comment
Closed

Remove ExtractImageDetailsDF.scala #464

ruebot opened this issue May 24, 2020 · 1 comment

Comments

@ruebot
Copy link
Member

@ruebot ruebot commented May 24, 2020

ExtractImageDetailsDF.scala came in while we were working on #223. At the time it was needed, but now it is basically redundant with ImageInformationExtractor.scala.

  1. ImageInformationExtractor.scala is tied to the ImageInformationExtractor spark-submit job
  2. ExtractImageDetailsDF is standalone, and is not documented anywhere other than doc comments.

The big difference between the two is ExtractImageDetailsDF includes the bytes column.

I propose we remove this now prior to the 1.0.0 release, and in the future if there is a demand for binary extract jobs, we can add them. Or just add a flag to the current jobs to include the bytes column 😉

@lintool @ianmilligan1 let me know if there is any strong disagreement with removing this.

@ruebot ruebot self-assigned this May 24, 2020
ruebot added a commit that referenced this issue May 24, 2020
@ianmilligan1
Copy link
Member

@ianmilligan1 ianmilligan1 commented May 24, 2020

This rationale makes sense to me! I'll look at the PR, and can merge unless any strong objections from @lintool.

@ianmilligan1 ianmilligan1 added this to Done in 1.0.0 Release of AUT via automation May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.