Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ExtractImageDetailsDF; resolves #464. #465

Merged
merged 1 commit into from May 24, 2020
Merged

Remove ExtractImageDetailsDF; resolves #464. #465

merged 1 commit into from May 24, 2020

Conversation

@ruebot
Copy link
Member

ruebot commented May 24, 2020

GitHub issue(s): #464

What does this Pull Request do?

Remove ExtractImageDetailsDF.

Rationale outlined in #464.

How should this be tested?

TravisCI

@ruebot ruebot requested review from lintool and ianmilligan1 May 24, 2020
@codecov
Copy link

codecov bot commented May 24, 2020

Codecov Report

Merging #465 into master will decrease coverage by 0.57%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #465      +/-   ##
==========================================
- Coverage   76.43%   75.86%   -0.58%     
==========================================
  Files          50       49       -1     
  Lines        1460     1442      -18     
  Branches      279      279              
==========================================
- Hits         1116     1094      -22     
- Misses        214      218       +4     
  Partials      130      130              
@ianmilligan1
Copy link
Member

ianmilligan1 commented May 24, 2020

And Jimmy gave me his +1!

@ianmilligan1 ianmilligan1 merged commit cfcbc48 into master May 24, 2020
2 of 3 checks passed
2 of 3 checks passed
codecov/project 75.86% (+-0.58%) compared to 69007e2
Details
codecov/patch Coverage not affected when comparing 69007e2...719f2a2
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ianmilligan1 ianmilligan1 deleted the issue-464 branch May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.