Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upPEP8 Naming - UDFs, App method names, DataFrame names, and filters. #468
Comments
My thoughts: In Python, I would default to PEP8 unless there's a convincing reason otherwise: https://www.python.org/dev/peps/pep-0008/ Apps are most like Classes, so I would go CamelCase. Note, it says:
UDFs are like methods, so should follow standard snake_case. |
@lintool anything on the Scala side? If not, I'll get some PRs ready for aut, documentation, and notebooks. |
|
Resolved with 8037745 |
Feel free to vote down if you think this ship has already sailed... Currently, we have However, for RDDs, we still have |
And also: https://github.com/archivesunleashed/aut-docs/blob/master/current/dataframe-schemas.md Thoughts about Python/Scala naming conventions? Right now we use small camel case. In Python DF, this goes against the best practice of downcased snake case. There are three relevant cases:
If we change to:
We would completely resolve any of these issues. And with this, I think I've said my peace on naming. |
Good call on the Scala side. It'll be nice to remove those RDD suffixes. I'll get the Scala side sorted out here in a bit. For the three additional cases, these two -- As for |
I think I'm fine with
Let's yank. |
ruebot commentedMay 27, 2020
Let's evaluate how we've named everything; UDFs, App method names, DataFrame names, and filters.
Are we all good with how we've named everything?
Do we need to change anything before a 1.0.0 release?
See also #467