Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Python UDF methods out of their own class. #475

Merged
merged 1 commit into from May 29, 2020
Merged

Conversation

@ruebot
Copy link
Member

ruebot commented May 29, 2020

GitHub issue(s): #467

What does this Pull Request do?

Move Python UDF methods out of their own class.

  • Resolve #467
  • README button colour tweak for UserDocs

How should this be tested?

- Resolve #467
- README button colour tweak for UserDocs
@ruebot ruebot requested a review from ianmilligan1 May 29, 2020
@codecov
Copy link

codecov bot commented May 29, 2020

Codecov Report

Merging #475 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #475   +/-   ##
=======================================
  Coverage   83.88%   83.88%           
=======================================
  Files          44       44           
  Lines        1297     1297           
  Branches      250      250           
=======================================
  Hits         1088     1088           
  Misses         80       80           
  Partials      129      129           
@@ -1,5 +1,39 @@
from aut.app import Extract_Popular_Images, Write_Gexf, Write_Graphml
from aut.common import WebArchive
from aut.udfs import Udf
from aut.udfs import (
compute_image_size,

This comment has been minimized.

Copy link
@lintool

lintool May 29, 2020

Member

All appropriately pythonic, 👍


__all__ = ["Extract_Popular_Images", "Udf", "WebArchive", "Write_Gexf", "Write_Graphml"]
__all__ = [
"Extract_Popular_Images",

This comment has been minimized.

Copy link
@lintool

lintool May 29, 2020

Member

Apologies in advance if this has been hashed out already, but have we agreed on a naming convention for these? Naming seems inconsistent at present...

This comment has been minimized.

Copy link
@ruebot
Copy link
Member

ianmilligan1 left a comment

Ran through the two provided notebooks with CPP sample data - thanks for those @ruebot. All works perfectly!

@ianmilligan1 ianmilligan1 merged commit 76c8247 into master May 29, 2020
3 checks passed
3 checks passed
codecov/patch Coverage not affected when comparing 4cd90dc...7afff70
Details
codecov/project 83.88% (+0.00%) compared to 4cd90dc
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ianmilligan1 ianmilligan1 deleted the issue-467 branch May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.