Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove RDD suffixes on file, class, and object names. #479
+134
−411
Conversation
- Remove all the RDD suffixes added previously - Rename presentationProgramFiles to presentationProgram (Scala) - Rename wordProcessorFiles to wordProcessor (Scala) - Rename image_graph to imagegraph (Python) - Rename textFiles to textfiles (Scala) - Rename text_files to textfiles (Python) - Rename files all affected files as needed - Update tests as needed
ruebot
added a commit
to archivesunleashed/aut-docs
that referenced
this pull request
Jun 1, 2020
Documentation updates are over here. They'll get in the website when the time comes. |
codecov
bot
commented
Jun 1, 2020
•
Codecov Report
@@ Coverage Diff @@
## master #479 +/- ##
==========================================
- Coverage 83.88% 83.69% -0.20%
==========================================
Files 44 43 -1
Lines 1297 1245 -52
Branches 250 239 -11
==========================================
- Hits 1088 1042 -46
Misses 80 80
+ Partials 129 123 -6 |
ruebot
added a commit
to archivesunleashed/aut-docs
that referenced
this pull request
Jun 1, 2020
ruebot
added a commit
to ruebot/aut-docs-redux
that referenced
this pull request
Jun 1, 2020
I think I caught a name inconsistency? |
src/main/scala/io/archivesunleashed/matchbox/GetExtensionMime.scala
Outdated
Show resolved
Hide resolved
lgtm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ruebot commentedJun 1, 2020
•
edited
GitHub issue(s): #468
What does this Pull Request do?
Remove RDD suffixes on file, class, and object names.
How should this be tested?
Additional Notes: