Gale Databases.js - New logic to access citation metadata #2076

ghost · 2019-12-02T19:00:49Z

No description provided.

ghost · 2019-12-02T19:28:03Z

Please publish update after 12/20/2019 in order to coordinate with Gale releases.

adam3smith · 2019-12-02T20:00:36Z

Thanks @jimmiazek . Looks good at first glance, I'll review for details next weekend the latest.

Just to confirm the data is December 20th? I believe I had December 16th from Megan.

dstillman · 2019-12-02T22:00:32Z

@jimmiazek: Can you revert the .gitignore change? (You can put this in a global ignore file on your system.)

ghost · 2019-12-02T22:03:44Z

@adam3smith - Original release date (12/16) has been moved to (12/20).

adam3smith · 2019-12-08T20:01:50Z

Thanks! Looks great overall. I have no concerns about the code itself. Except two quick ones that I think are just due to the testing stage of this:

The tests will need to get updated once the site is live. do you know already what the hostname will be?
Currently you have commented out the metadata JSON block. Please re-enable that

Some remaining issues on import quality:

I get the starting(?) page in extra occasionally, e.g. for
https://link.qa.galetesting.com/apps/doc/A597223700/AONE?u=zotero&sid=AONE&xid=b1ebba12
coming from the M2 tag in the RIS. I think it'd be best to just ignore the M2 tag unless it solves some other function
Missing page numbers are (sometimes?) turned into NA such as on
https://link.qa.galetesting.com/apps/doc/A599824399/AONE?u=zotero&sid=AONE&xid=3ea3b5f9
that should just be removed during import
Your detect function looks like it sometimes produces better item type mappings than Zotero's RIS import. E.g. for https://link.qa.galetesting.com/apps/doc/CCUUVM394664614/NCCO?u=zotero&sid=NCCO&xid=1f6d5d40 it detects (correctly) as a manuscript, but Zotero, not knowing the UNPB label on the RIS, imports as journal article. Unfortunately that's not always the case. E.g. in the Literature Resource center, the RIS is much better: https://link.qa.galetesting.com/apps/doc/A598538032/LitRC?u=zotero&sid=LitRC&xid=51c6b9d6 is correctly classified as a magazine article, rather than a document.
I'm open for ideas here, but my suggestion would be to check were the two disagree, go with the zoter-label element when the RIS imports as journals and stick with the RIS otherwise.

Let me know if you have any questions about this.


        Jim/Eric : Gale Databases.js - New logic to access citation metadata

ghost · 2019-12-11T15:01:14Z

@adam3smith - made the code changes that you asked to uncomment the JSON object -- I believe this is what is causing Travis to fail. Production server is gale.com. Applied your suggestion for M2 and SP tags.

For your analysis, regarding the differences for detectWeb and doWeb. This is something that will have to be addressed in the future. The doWeb is using a REST client to retrieve RIS. The detectWeb makes a different call to get different data to render the display.

adam3smith · 2019-12-11T15:04:04Z

Thanks -- I'll take a look at why linting fails. I'd guess Windows EoL for the JSON header, but either way, I should be able to fix that quickly on my end.

dstillman · 2019-12-12T10:07:52Z

Gale Databases.js

+	'inRepository': true,
+	'translatorType': 4,
+	'browserSupport': 'gcsibv',
+	'lastUpdated': '2019-10-11 12:00:00'


You need to revert these quote changes, which will break the translator. (For historical reasons, this is JSON, not JavaScript.)

dstillman · 2019-12-12T10:11:48Z

Gale Databases.js


+var GaleZotero = (function () {


There's no need for this encapsulation. Just put the relevant code in detectWeb() and doWeb() and define other top-level helper functions as necessary.

dstillman · 2019-12-12T10:13:28Z

Gale Databases.js


+var GaleZotero = (function () {
+var DATA_TRANSLATOR = '32d59d2d-b65a-4da4-b0a3-bdd3cfb979e7';


This can just go directly in the translator.setTranslator() call below (as in all other translators), with a comment noting that it's RIS.

dstillman · 2019-12-12T10:13:40Z

Gale Databases.js

-		items[href] = title;
+}
+
+function processMulipleEntries(entries) {


dstillman · 2019-12-12T10:18:09Z

Gale Databases.js

+	var map = {};
+	for (var item in entries) {
+		/* istanbul ignore next */
+		if (entries.hasOwnProperty(item)) {


This check isn't necessary — Object.prototype will never be overridden in the contexts where this will run.

dstillman · 2019-12-12T10:18:27Z

Gale Databases.js

+function getURLs(selectedItems) {
+	var urls = [];
+	for (var url in selectedItems) {
+		if (selectedItems.hasOwnProperty(url)) {


Not necessary

dstillman · 2019-12-12T10:20:42Z

Gale Databases.js

 			}
 		]
 	}
-]
+]; // eslint-disable-line


dstillman · 2019-12-12T10:21:56Z

Gale Databases.js

+						note: "<p>Northern Illinois University</p>"
+					}
+				],
+				seeAlso: []


Please revert all the quote changes in these test cases. These tests should be generated by Scaffold and shouldn't be reformatted.

dstillman · 2019-12-12T10:24:37Z

Gale Databases.js

 /** BEGIN TEST CASES **/
+// eslint-disable-next-line no-unused-vars


Remove all these eslint-disable lines. You should be using this repo's lint rules, which should handle all of this properly.

dstillman · 2019-12-12T10:27:21Z

(Re: all of these comments, I'm guessing you were developing this code outside of the Translator Editor, with a different environment and different lint rules. We strongly recommend developing within the editor, and you should check the code with eslint within the repo, which should use the bundled lint rules. Among other things, the rules will ensure it's a valid translator, which this isn't.)

adam3smith · 2019-12-23T14:27:10Z

@jimmiazek a bit confused why you closed this and deleted the branch? What´s the status of the updated site and code?

dstillman · 2019-12-25T05:49:43Z

It looks like the account was deleted.

adam3smith · 2019-12-25T09:22:08Z

how very odd & unfortunate...

zuphilip · 2019-12-25T09:23:33Z

We can still take the old version of this PR and build on top of that our changes. Give me some minutes to come up with something...

adam3smith · 2019-12-25T09:28:24Z

Thanks -- we should check that they did, in fact, update their site on the 20th. Otherwise these changes won't work.

adam3smith · 2019-12-25T09:33:37Z

Update: yes, it looks like all of Gale is update, so this would be nice to get in.

zuphilip · 2019-12-25T09:45:04Z

Continued in #2096.

adam3smith self-assigned this Dec 2, 2019

adam3smith mentioned this pull request Dec 5, 2019

Gale Databases - updated connector #2071

Closed

Jim/Eric : Gale Databases.js - New logic to access citation metadata

Loading status checks…

2f3ee50

dstillman reviewed Dec 12, 2019

View changes

Gale Databases.js

items[href] = title;

}

function processMulipleEntries(entries) {

This comment has been minimized.

Sign in to view

Copy link

dstillman Dec 12, 2019
Member

Typo

dstillman reviewed Dec 12, 2019

View changes

Gale Databases.js

function getURLs(selectedItems) {

var urls = [];

for (var url in selectedItems) {

if (selectedItems.hasOwnProperty(url)) {

This comment has been minimized.

Sign in to view

Copy link

dstillman Dec 12, 2019
Member

Not necessary

dstillman reviewed Dec 12, 2019

View changes

Gale Databases.js

}

]

}

]

]; // eslint-disable-line

This comment has been minimized.

Sign in to view

Copy link

dstillman Dec 12, 2019
Member

Revert

dstillman reviewed Dec 12, 2019

View changes

ghost closed this Dec 23, 2019

ghost deleted the gale-zotero branch Dec 23, 2019

zuphilip mentioned this pull request Dec 25, 2019

Update Gale Databases #2096

Open

This issue was closed.

Please note that GitHub no longer supports your web browser.

zotero/translators

Join GitHub today

Gale Databases.js - New logic to access citation metadata #2076

Gale Databases.js - New logic to access citation metadata #2076

Conversation

ghost commented Dec 2, 2019

This comment has been minimized.

ghost commented Dec 2, 2019

This comment has been minimized.

adam3smith commented Dec 2, 2019

This comment has been minimized.

dstillman commented Dec 2, 2019

This comment has been minimized.

ghost commented Dec 2, 2019

This comment has been minimized.

adam3smith commented Dec 8, 2019

This comment has been minimized.

ghost commented Dec 11, 2019

This comment has been minimized.

adam3smith commented Dec 11, 2019

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

dstillman commented Dec 12, 2019 • edited

This comment has been minimized.

adam3smith commented Dec 23, 2019

This comment has been minimized.

dstillman commented Dec 25, 2019

This comment has been minimized.

adam3smith commented Dec 25, 2019

This comment has been minimized.

zuphilip commented Dec 25, 2019

This comment has been minimized.

adam3smith commented Dec 25, 2019

This comment has been minimized.

adam3smith commented Dec 25, 2019

This comment has been minimized.

zuphilip commented Dec 25, 2019

dstillman commented Dec 12, 2019 •

edited