Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate Gale Databases #2096
Update Gale Databases #2096
Conversation
This comment has been minimized.
This comment has been minimized.
Okay, I did some more simplification. Should be fine from my side. However, I think that I have only have very limited access to Gale DB. |
This comment has been minimized.
This comment has been minimized.
I added a fix for multiples. |
This comment has been minimized.
This comment has been minimized.
Thank you for the fix! I couldn't test multiples because I don't have much access to the Gale DBs. |
This comment has been minimized.
This comment has been minimized.
@dstillman -- are you able to test multiples successfully? I consistently get an error message (entry is null), presumably because the page isn't fully loaded when |
This comment has been minimized.
This comment has been minimized.
I tried now with this URL in Gale Primary Sources - British Library Newspapers (searched for "save dog") and it works fine in Scaffold as well as in the browser. The new added monitorDOMChanges should be taking care about the dynamic loading of the website. However, in Scaffold this shouldn't even be needed because you can simply wait until the page is loaded and only afterwards click on the detectWeb button. Which URL resp. search did you try? |
This comment has been minimized.
This comment has been minimized.
It might have to do with the proxy? When I try to follow the link given by in the I just tried going through the regular article link instead (i.e. just |
This comment has been minimized.
This comment has been minimized.
Just tried again and this isn't due to the proxy. https://link.gale.com/apps/doc/A602462094/PROF?u=nysl_ce_syr&sid=zotero&xid=18c0fad7 fails, too |
This comment has been minimized.
This comment has been minimized.
elamgit
commented
Jan 15, 2020
@adam3smith I think the issue is specific to your library's EZProxy. I will investigate further and get back. Thanks. |
This comment has been minimized.
This comment has been minimized.
Thanks @elamgit for looking into this. Let us know if this is fixable on your end. Otherwise I think we can find other ways to get the multiples, but the dedicated Zotero class is particularly robust, so it'd be nice to keep. |
This comment has been minimized.
This comment has been minimized.
elamgit
commented
Jan 16, 2020
•
@adam3smith, Can you try now? I made a configuration change at Gale. You should not be getting the "document could not be retrieved" error message anymore. |
This comment has been minimized.
This comment has been minimized.
Thanks @elamgit -- initial tests looking good. I'll run through a couple more pages, but I think we're good to merge here. Any remaining concerns from your end? |
This comment has been minimized.
This comment has been minimized.
elamgit
commented
Jan 17, 2020
@adam3smith, I agree. No concerns from me and everything is looking good. Thanks. |
This comment has been minimized.
This comment has been minimized.
Thanks everyone! Looking great now. |
zuphilip commentedDec 25, 2019
•
edited
This continues the work of #2076.
Note: I was in a hurry and therefore did not spent too much time in any further update.