Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gale Databases #2096

Merged
merged 4 commits into from Jan 18, 2020
Merged

Update Gale Databases #2096

merged 4 commits into from Jan 18, 2020

Conversation

@zuphilip
Copy link
Collaborator

zuphilip commented Dec 25, 2019

This continues the work of #2076.

Note: I was in a hurry and therefore did not spent too much time in any further update.

Jim/Eric and others added 2 commits Dec 11, 2019
@zuphilip

This comment has been minimized.

Copy link
Collaborator Author

zuphilip commented Dec 25, 2019

Okay, I did some more simplification. Should be fine from my side. However, I think that I have only have very limited access to Gale DB.

@dstillman

This comment has been minimized.

Copy link
Member

dstillman commented Dec 25, 2019

I added a fix for multiples.

@zuphilip

This comment has been minimized.

Copy link
Collaborator Author

zuphilip commented Dec 25, 2019

Thank you for the fix! I couldn't test multiples because I don't have much access to the Gale DBs.

@adam3smith

This comment has been minimized.

Copy link
Collaborator

adam3smith commented Dec 26, 2019

@dstillman -- are you able to test multiples successfully? I consistently get an error message (entry is null), presumably because the page isn't fully loaded when processSingleEntry fires. Happens in both Firefox and Scaffold.

@zuphilip

This comment has been minimized.

Copy link
Collaborator Author

zuphilip commented Dec 26, 2019

I tried now with this URL in Gale Primary Sources - British Library Newspapers (searched for "save dog") and it works fine in Scaffold as well as in the browser. The new added monitorDOMChanges should be taking care about the dynamic loading of the website. However, in Scaffold this shouldn't even be needed because you can simply wait until the page is loaded and only afterwards click on the detectWeb button. Which URL resp. search did you try?

@adam3smith

This comment has been minimized.

Copy link
Collaborator

adam3smith commented Dec 29, 2019

It might have to do with the proxy? When I try to follow the link given by in the zotero-label section, e.g. https://link-gale-com.libezproxy2.syr.edu/apps/doc/A609314409/AONE?u=nysl_ce_syr&sid=zotero&xid=ff03afdf it takes me to https://go-gale-com.libezproxy2.syr.edu/ps/i.do?p=AONE&userGroupName=nysl_ce_syr and "document could not be retrieved.

I just tried going through the regular article link instead (i.e. just h3 a) and that's working. That's on Academic one file, but might be more fragile since you're relying on identical page structure.

@adam3smith

This comment has been minimized.

Copy link
Collaborator

adam3smith commented Jan 15, 2020

Just tried again and this isn't due to the proxy. https://link.gale.com/apps/doc/A602462094/PROF?u=nysl_ce_syr&sid=zotero&xid=18c0fad7 fails, too

@elamgit

This comment has been minimized.

Copy link

elamgit commented Jan 15, 2020

@adam3smith I think the issue is specific to your library's EZProxy. I will investigate further and get back. Thanks.

@adam3smith

This comment has been minimized.

Copy link
Collaborator

adam3smith commented Jan 16, 2020

Thanks @elamgit for looking into this. Let us know if this is fixable on your end. Otherwise I think we can find other ways to get the multiples, but the dedicated Zotero class is particularly robust, so it'd be nice to keep.

@elamgit

This comment has been minimized.

Copy link

elamgit commented Jan 16, 2020

@adam3smith, Can you try now? I made a configuration change at Gale. You should not be getting the "document could not be retrieved" error message anymore.

@adam3smith

This comment has been minimized.

Copy link
Collaborator

adam3smith commented Jan 17, 2020

Thanks @elamgit -- initial tests looking good. I'll run through a couple more pages, but I think we're good to merge here. Any remaining concerns from your end?

@elamgit

This comment has been minimized.

Copy link

elamgit commented Jan 17, 2020

@adam3smith, I agree. No concerns from me and everything is looking good. Thanks.

@adam3smith adam3smith merged commit d77ae04 into zotero:master Jan 18, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Copy link
Collaborator

adam3smith commented Jan 18, 2020

Thanks everyone! Looking great now.
I'm leaving the two other Gale translators in place for now. It looks like the resources they point to still exist, though they're gradually being phased out (e.g. ECCO is also available through Primary Sources, which is covered by this translator). Since the other translators detect for different URLs, there's no harm in keeping them, at least for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.