Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign uptake abstract from RIS and pages from RIS for Nat. Comm. #2165
+553
−532
Conversation
|
@adam3smith, could you look at issue #2164 too? taking the abstract from the RIS in this commit works, but the problem could also be fixed by changing some of the upstream translators. I just don't know if what they're doing is intentional, in which case the fix probably should be to take the abstract from RIS here, or if its not then maybe its causing problems in other translators too? |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
vancleve commentedApr 19, 2020
The NPG translator seems to get the wrong abstract (see #2164) and Nature Communications needs the article number in the
pagesfield, not the PDF pages (see https://forums.zotero.org/discussion/82431/nature-communications-article-number).